镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Allow Activity registers actions of share and unshare for circles #9451 - #9463

Closed
fgsl wants to merge 1 commit into
nextcloud:masterfrom
fgsl:issue9451
Closed

fgsl wants to merge 1 commit into
nextcloud:masterfrom
fgsl:issue9451

Conversation

@fgsl

@fgsl fgsl commented May 11, 2018

Copy link
Copy Markdown

Description in: #9451

@codecov

codecov Bot commented May 11, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9463 into master will decrease coverage by 45.05%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #9463       +/-   ##
============================================
- Coverage     51.61%   6.56%   -45.06%     
- Complexity    25694   25706       +12     
============================================
  Files          1638    1638               
  Lines         96318   96345       +27     
  Branches       1393    1393               
============================================
- Hits          49713    6321    -43392     
- Misses        46605   90024    +43419
Impacted Files Coverage Δ Complexity Δ
...ps/files_sharing/lib/Activity/Providers/Groups.php 0% <0%> (ø) 34 <0> (+12) ⬆️
lib/public/AppFramework/Http/JSONResponse.php 0% <0%> (-100%) 5% <0%> (ø)
lib/public/AppFramework/Http/DownloadResponse.php 0% <0%> (-100%) 1% <0%> (ø)
lib/private/Hooks/ForwardingEmitter.php 0% <0%> (-100%) 5% <0%> (ø)
apps/dav/lib/CalDAV/Activity/Setting/Event.php 0% <0%> (-100%) 8% <0%> (ø)
lib/private/DB/QueryBuilder/QueryFunction.php 0% <0%> (-100%) 2% <0%> (ø)
core/Command/Background/Cron.php 0% <0%> (-100%) 1% <0%> (ø)
lib/private/Repair/NC11/FixMountStorages.php 0% <0%> (-100%) 5% <0%> (ø)
apps/user_ldap/lib/LDAPProviderFactory.php 0% <0%> (-100%) 2% <0%> (ø)
...c/AppFramework/Http/EmptyContentSecurityPolicy.php 0% <0%> (-100%) 45% <0%> (ø)
... and 882 more

@rullzer rullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just create a activity provider in the circles app?

@rullzer

rullzer commented May 23, 2018

Copy link
Copy Markdown
Member

Please implement this in the circles app (see https://github.com/nextcloud/activity/tree/master/docs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants