Repository navigation
Conversation
Node.source is decoded, so a # or ? in the destination path was parsed as a URL fragment or query and the existence check and MKCOL hit a truncated prefix. Build the webdav client from encodedSource and keep the decoded source for the created node. Assisted-by: ClaudeCode:claude-sonnet-5-5 Assisted-by: ClaudeCode:claude-opus-5-5 Assisted-by: Codex:gpt-5.6 Assisted-by: Grok:grok-4.6 Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
solracsf
force-pushed
the
fix/files-drop-encoded-destination
branch
from
October 22, 2026 12:50
9287a7f to
3622627
Compare
Member
Author
|
/backport to stable35 |
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createDirectoryIfNotExistsbuilt its WebDAV client from the decodeddestination.source, so a#or?anywhere in the destination path was read as a URL fragment or query. Dropping a folder into#testsent the existence check to the user root (no folder created, every file 404), and dropping intoa#bcreated a stray/a.The client is now built from
destination.encodedSource. The created node keeps the decoded source.Only drag and drop is fixed. The "Upload folder" button hits the same problem in
@nextcloud/upload(nextcloud-libraries/nextcloud-upload#1964), so #62716 is not fully resolved by this PR.Affects stable33, stable34 and stable35 (introduced by #59294).
Checklist
3. to review, feature component)stable32)AI (if applicable)
AI disclosure
This PR has been assisted by a multi-agentic setup including the following models: