镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix(files_sharing): public share popover jumps on options toggle - #65142

Merged
AndyScherzinger merged 1 commit into
masterfrom
fix/files_sharing__prevent-popover-dialog-flip
Oct 25, 2026
Merged

AndyScherzinger merged 1 commit into
masterfrom
fix/files_sharing__prevent-popover-dialog-flip

Conversation

@ShGKme

@ShGKme ShGKme commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Public share creation popover dialog has dynamically added elements like password and date expiration
  • On some screen sizes toggling them results in the popover jump (flip)
  • placement="auto" fixes the issue
    • Now it is always on the side and moves freely on size change
    • Unlike many other places, it looks well because the trigger is on the page edge
  • I don't think a more general solution is needed:
    • The only other similar place on server is the weather status widget, which is less disturbing
  • NcPopover's flip=false or shiftCrossAxis do not help. They prevent jump by allowing overflowing...
Before After
before after

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@ShGKme ShGKme added this to the Nextcloud 36 milestone Oct 5, 2026
@ShGKme
ShGKme requested review from provokateurin and susnux October 5, 2026 14:28
@ShGKme ShGKme self-assigned this Oct 5, 2026
@ShGKme
ShGKme requested a review from a team as a code owner October 5, 2026 14:28
@ShGKme
ShGKme requested review from kristian-zendato and sorbaugh and removed request for a team October 5, 2026 14:28
@ShGKme

ShGKme commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable35 please

@ShGKme

ShGKme commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable34 please

@ShGKme

ShGKme commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable33 please

@ShGKme

ShGKme commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable32 please

@ShGKme

ShGKme commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable31 please

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@AndyScherzinger
AndyScherzinger force-pushed the fix/files_sharing__prevent-popover-dialog-flip branch from e6fc19c to d56df9f Compare October 25, 2026 21:57
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked because it has been closed for more than 7 days. As we do not monitor merged or closed pull requests, we are locking this pull request to prevent further comments from getting lost in the noise.
If you discovered any issues with this pull request, please open a new issue instead. In case you want to discuss this pull request or have further questions, please use our forum: https://help.nextcloud.com

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants