Repository navigation
fix(Filesystem): use FilenameValidator for Filesystem::isFileBlacklisted - #54821
Merged
Merged
Conversation
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
…sted` This fixes the issue that some methods will not allow uploading files because they still require the deprecated config option to be used. So instead we need to use the validator introduced in v30. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/use-filename-validator-for-filesyste
branch
from
September 2, 2025 17:02
ffb718b to
a31e520
Compare
susnux
marked this pull request as ready for review
September 2, 2025 17:58
susnux
requested review from
come-nc,
icewind1991 and
salmart-dev
and removed request for
a team
September 2, 2025 17:58
AndyScherzinger
approved these changes
Sep 2, 2025
CarlSchwan
approved these changes
Sep 3, 2025
This was referenced Sep 3, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forbidden_filenamesis not considered in blacklist checkblacklisted_files#49014Summary
This fixes the issue that some methods will not allow uploading files because they still require the deprecated config option to be used. So instead we need to use the validator introduced in v30.
Checklist