Repository navigation
fix(IRegistrationContext): Add missing TaskProcessing methods - #45345
Merged
provokateurin merged 1 commit intoMay 16, 2024
Merged
provokateurin merged 1 commit into
provokateurin merged 1 commit into
Conversation
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
requested review from
andrey18106,
bigcat88,
julien-nc and
marcelklehr
May 16, 2024 07:56
marcelklehr
approved these changes
May 16, 2024
marcelklehr
left a comment
Member
There was a problem hiding this comment.
Strange that the CI was green when I merged.
Member
Author
|
Well the server CI is fine because the method is never called here. Just trying to call it from app_api it complains because the method is missing on the interface. |
bigcat88
approved these changes
May 16, 2024
julien-nc
approved these changes
May 16, 2024
provokateurin
deleted the
fix/iregistrationcontext/add-missing-taskprocessing-methods
branch
May 16, 2024 10:59
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up for #45094. The methods are present in the implementation but not in the interface, so the interface is not complete and also psalm complains about it.
Checklist