镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Compile contactmenu handlebars templates - #11414

Merged
MorrisJobke merged 1 commit into
masterfrom
csp/11029/contacts_menu_compiled_handlebars
Sep 28, 2018
Merged

MorrisJobke merged 1 commit into
masterfrom
csp/11029/contacts_menu_compiled_handlebars

Conversation

@rullzer

@rullzer rullzer commented Sep 27, 2018

Copy link
Copy Markdown
Member

Fixes #11029
For https://github.com/orgs/nextcloud/projects/18

Ship the compiled handlebars templates. This makes it possible to have a
scricter CSP.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@danxuliu danxuliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #11029
For https://github.com/orgs/nextcloud/projects/18

Ship the compiled handlebars templates. This makes it possible to have a
scricter CSP.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
rullzer force-pushed the csp/11029/contacts_menu_compiled_handlebars branch from 9d962aa to c9e93b8 Compare September 27, 2018 18:34
@danxuliu

Copy link
Copy Markdown
Member

For future reference, to know how to update the templates see this note in filesummary.js (maybe it would be a good idea to include the note in contactsmenu.js too? Although if more and more templates are compiled we would end having the same note everywhere).

@ChristophWurst

Copy link
Copy Markdown
Member

For future reference, to know how to update the templates see this note in filesummary.js (maybe it would be a good idea to include the note in contactsmenu.js too? Although if more and more templates are compiled we would end having the same note everywhere).

As discussed in private IRC with @rullzer, I would suggest to add a script that builds all Handlebars templates at once. That will make it easier for devs and also enable us to easily check if they are up to date on CI.

@MorrisJobke MorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works 👍

@MorrisJobke
MorrisJobke merged commit e204700 into master Sep 28, 2018
@MorrisJobke
MorrisJobke deleted the csp/11029/contacts_menu_compiled_handlebars branch September 28, 2018 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants