镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Compile handlebars template for AuthTokenView - #11412

Merged
ChristophWurst merged 1 commit into
masterfrom
csp/11032/authtoekn_compiled_handlebars
Sep 28, 2018
Merged

ChristophWurst merged 1 commit into
masterfrom
csp/11032/authtoekn_compiled_handlebars

Conversation

@rullzer

@rullzer rullzer commented Sep 27, 2018

Copy link
Copy Markdown
Member

Fixes #11032
For https://github.com/orgs/nextcloud/projects/18

Compile the default authtoken handlebars view.
This avoids runtime compilations (speed) and avoids unsafe eval calls
thus allowing a stricter CSP.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

Fixes #11032
For https://github.com/orgs/nextcloud/projects/18

Compile the default authtoken handlebars view.
This avoids runtime compilations (speed) and avoids unsafe eval calls
thus allowing a stricter CSP.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

@MorrisJobke MorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and does still work 👍

@rullzer

rullzer commented Sep 27, 2018

Copy link
Copy Markdown
Member Author

All green 🎉

@ChristophWurst ChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 as dicussed

@ChristophWurst
ChristophWurst merged commit 9eb4259 into master Sep 28, 2018
@ChristophWurst
ChristophWurst deleted the csp/11032/authtoekn_compiled_handlebars branch September 28, 2018 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants