Repository navigation
[Bug]: Loginflow v1 broken on master #51618
Description
⚠️ This issue respects the following points: ⚠️
- This is a bug, not a question or a configuration/webserver/proxy issue.
- This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
- Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
- I agree to follow Nextcloud's Code of Conduct.
Bug description
13fe0f561245536be6ce440d5d62316150cc9f19 is the first bad commit
commit 13fe0f561245536be6ce440d5d62316150cc9f19
Author: Côme Chilliet <come.chilliet@nextcloud.com>
Date: Tue Mar 11 11:31:59 2025 +0100
fix: Clean up typing and remove deprecated calls in template functions
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
lib/private/Template/functions.php | 62 +++++++++++++++++++++-----------------
1 file changed, 35 insertions(+), 27 deletions(-)
Issue comes from here for login flow v1:
server/core/templates/loginflow/grant.php
Line 37 in abdb432
So the new type annotation at
server/lib/private/Template/functions.php
Line 16 in 13fe0f5
Is the problem.
Same issue also happens when opening the server info app (and maybe other apps as well).
CC @come-nc
Activity
susnux commentedon Mar 21, 2025
@come-nc maybe we should type it mixed and add a cast within that function like:
come-nc commentedon Mar 24, 2025
I missed that there was no soft typing before. But then it’s passed to sanitizeHTML which expects a string.
If we remove the strong typing we should add a soft one in phpdoc, and still fix all the calls.
come-nc commentedon Mar 24, 2025
Also this means we are missing a test in CI for loginflow v1 😛