镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Search provider names in unified search hint do not respect localized language rules #25282

Closed

Description

@blizzz

Fits:

Screenshot_20210122_182232

Should be capitalised:

Screenshot_20210122_182352

It is not a translation issue. The search providers only have to provide a getName() method for a translated string. The provides all return it in capitalized fashion ("Apps", …). In core/src/views/UnifiedSearch.vue:47 they are hard-lowercased.

The best distinction is done by the translators however.

My suggestion would be to add another method (as another interface to avoid breakage) that would return a string to be used within a sentence. And fall back to getName(). The hard lowercasing in the view would be removed.

The alternative would be to only remove the forced lower cased, which would end up in a strange picture at least in English:

Screenshot_20210122_183238

@ChristophWurst @skjnldsv @jancborchardt what do you think?

Activity

  1. nickvergessen commented on Jan 25, 2021

    @nickvergessen
    Member

    :placeholder="t('core', 'Search {types} …', { types: typesNames.join(', ').toLowerCase() })"

    We already agreed on this before to drop the lower

  2. ChristophWurst commented on Jan 25, 2021

    @ChristophWurst
    Member

    👍 I actually thought we had fixed that during Nextcloud 20 development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions