Repository navigation
Notifications from past events are not automatically dismissed #25111
Description
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Expected behaviour
Events from the past should not generate reminder notifications in the future, and definitely not every hour.
Actual behaviour
Desktop app continues to issue reminder notifications for events from the past. The notification text clearly states that the event was "2 hours ago" etc. There is no way to dismiss them to stop them from coming back.
The user's dashboard on the server also shows the events from the past, eg:
Steps to reproduce
- Create an event in Nextcloud Calendar using iOS Apple Calendar app using default settings.
- Wait till the event time or date passes.
- Make sure Nextcloud macOS app is running.
- Within the next hour, and then again every hour, a notification will be generated by the Nextcloud desktop app reminding you about the event from the past.
- To stop this, you need to delete the event. Removing reminders from the event sometimes helps but the only way to be sure is to delete the event itself.
Client configuration
Client version:
Nextcloud Desktop Client Version 3.1.1 (macOS)
Operating system:
macOS Catalina 10.15.7
OS language:
English
Installation path of client:
/Applications/nextcloud
Server configuration
Nextcloud version: 20.0.4
Logs
I will submit relevant logs if and when someone decides to debug this issue.
Activity
er-vin commentedon Jan 13, 2021
I'm not sure I understand the problem correctly. Is the problem that the desktop client wrongly show the notification? Or that the server wrongly show the notification?
Because if you have the issue on the server side the desktop client will just mirror it, that's to be expected.
RafalLukawiecki commentedon Jan 13, 2021
Thanks for asking, @er-vin. I think there may be two issues. First of all, Nextcloud server is showing reminders from the past. Secondly, the desktop app repeatedly notifies of them. The second issue causes the annoyance (being reminded of past events once an hour) whilst the first issue could be the root cause.
I am new to the Nextcloud ecosystem. Feel free to move or copy this issue to the relevant repository. Thank you.
er-vin commentedon Jan 13, 2021
Right, I'll move it over to the calendar app, this seems to be the root cause to me. The desktop client will just display those as long as they get displayed on the server.
tcitworld commentedon Jan 13, 2021
The main issue is probably that old calendar reminders stay as notifications at long as they're not dismissed.
Unfortunately we remove the reminder once the notification is sent, so there's no way to dismiss it automatically once the event has started with the current way it works. Otherwise we need to mark the reminder as processed, and only once the event has passed, dismiss the notification and then only remove the reminder from database.
@nickvergessen Otherwise, maybe notifications could be auto-dismissable with a
setExpirationDatemethod?[-]Notifications keep coming for calendar events from the past using macOS desktop Nextcloud app[/-][+]Notifications from past events are not automatically dismissed[/+]nickvergessen commentedon Jan 13, 2021
They can be expired on rendering by the provider.just throw an
OCP\Notifications\AlreadyProcessedExceptionRafalLukawiecki commentedon Jan 13, 2021
Thank you @nickvergessen and @tcitworld for taking this up. From end-user perspective the notification that the app generates is prominent enough to warrant no further re-notifications. If the end user wishes this notification to be even more prominent there are options both in iOS and macOS to persist the notifications from Nextcloud app until dismissed. Normally, however, I would not expect notifications to keep recurring once they have been served.
It sounds to my novice ears that expiring them on rendering makes sense.