Repository navigation
Unify select mechanisms/widgets #1831
Description
Currently we use 4 different things:
<select>– simplest from the browser directly- select2 – allows for tag widgets for example
- jQuery autocomplete – used in sharing and Mail app autocomplete
- our core/js/multiselect.js –
used mostly in user mgmt for group memberships because it allows you to add new elements (like for the Github labels and Milestones dropdown).
@nextcloud/javascript & @nextcloud/designers would it be possible to maybe decide on one or maximum two to use consistently?
Also cc @georgehrke @ChristophWurst @schiessle @Henni @icewind1991 because these things are heavily used in apps and user management.
Where are they used:
-
/apps/user_ldap/vendor/ui-multiselect/src/jquery.multiselect.jsin the LDAP app:
- select2 core:
- files_external
- systemtags
- workflowengine
- settings (group select)
- select2 apps:
- announcementcenter
- bookmarks
- circles
- contacts
- dicomviewer
- files_automatedtagging
- files_retention
- richdocuments
- sensorlogger
- spreed
Activity
skjnldsv commentedon Oct 20, 2016
:D
Clearly will help regroup the various styles we're using.
See #1805 for all the fixes we got
MorrisJobke commentedon Oct 20, 2016
I already tried to do so, but it sounds easier than it actually is. This is a really tough task, but we should do.
skjnldsv commentedon Mar 20, 2018
While the vuejs apps start rolling out, my choice has been into vue-multiselect. Which allows tagging, creation, multi and simple select. I implemented the new design into the vu settings migration here #8824 .
Looks very nice, supports array and objects, is highly supported... :)
jancborchardt commentedon Jun 23, 2018
@skjnldsv good stuff! Do we still need to have this open for tracking, like do you have an overview where the old method of select is still used where it needs to be replaced?
skjnldsv commentedon Jun 23, 2018
Yes because we still have some old legacy stuff laying around! :)
rullzer commentedon Jun 23, 2018
@skjnldsv feel free to update the first comment to list all the remaining things that need to be cleaned up. So people can easily see/track/tackle/fix it ;)
MorrisJobke commentedon Jun 25, 2018
I added the stuff for select2 and
core/js/multiselectskjnldsv commentedon Jun 25, 2018
Thanks @MorrisJobke
2 remaining items
skjnldsv commentedon Mar 14, 2019
I guess this is just a matter of deprecating it so we can unship the libs in 3 versions :)
MorrisJobke commentedon Mar 14, 2019
In reality we also need to move our own stuff away from it. 😉 (that is the real major part after deprecating something)
PVince81 commentedon Sep 29, 2022
regarding select2 I just grepped the 25.0.0 beta6 tarball and found these usages: