镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Add template renderas empty #10142

Open
Open

Description

@rullzer

Richdocuments renders all their templates as empty. This is done because we embed the view in an iframe and we do not need the top bar etc etc.

This works because the old code never checks the render as value as being one of the valid ones.

I'd vote to make this an official mode. And then also make sure that we kill javascript that doesn't belong there (for example the search stuff).

CC: @nickvergessen @MorrisJobke

Activity

  1. nextcloud-bot commented on Jul 7, 2018

    @nextcloud-bot
    Member

    GitMate.io thinks possibly related issues are #5534 (Empty trash), #10128 (Add locale to templates), #9529 (Template file), #74 (Add Automatic Tagging), and #6553 (Add public page template for apps).

  2. nickvergessen commented on Jul 9, 2018

    @nickvergessen
    Member

    So then there are 3? '', 'blank' and 'empty' ?

    I'd vote for "add constants and unify the usage", because f#$k magic strings 😎

  3. nickvergessen commented on Jul 9, 2018

    @nickvergessen
    Member

    And btw blank and empty are used since 4+ years:

    $renderAs = $this->renderAs === 'blank' ? '' : $this->renderAs;

  4. rullzer commented on Jul 9, 2018

    @rullzer
    MemberAuthor

    Yes lets add them as constants!

    Also if they are there already we should exclude some js loading on blank and empty etc.

  5. szaimen commented on May 26, 2021

    @szaimen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions