Repository navigation
[stable29] fix(browser): Don't create web notifications for old notifications - #1945
Merged
Merged
Conversation
Sometimes a notification got "newly mounted" while being old. This can happen when a user has many notifications (100-1). The UI first only loads (100-76), if any notification is then resolved (e.g. by deleting or reading a chat), further old notifications (75+74) would be added to the UI and triggered a web notification (including call sound) in the past. This threshold ID is therefore updated to only higher values, before each pulling of notifications to ensure that we only ever web-notify on new notifications and not newly loaded old notifications. Signed-off-by: Joas Schilling <coding@schilljs.com>
Member
|
/compile / |
nickvergessen
approved these changes
Jun 10, 2024
nickvergessen
enabled auto-merge
June 10, 2024 12:38
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1943
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.