You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, when parse fails, the user only gets a very uninformative error string as a result.
It would be nice to have a custom error type with useful functionality , such as knowing where the error happened.
Yes! I've been meaning to add support for more descriptive syntax errors for a while, but never got around to it. Independently, I believe nom's story for parse error handling has also changed, however, so it might be best do to this alongside a port to nom v4.
To add to this issue: Specifically we should use nom's VerboseError to improve error messages. One thing pointed out by @spazm is that in src/create.rs, the creation function, might want to through a nom error with descriptive error message rather than the existing assert!(table.alias.is_none())
Activity
lovasoa commentedon Sep 19, 2018
See lovasoa@a0e27ac
ms705 commentedon Oct 3, 2018
Yes! I've been meaning to add support for more descriptive syntax errors for a while, but never got around to it. Independently, I believe
nom's story for parse error handling has also changed, however, so it might be best do to this alongside a port to nom v4.ms705 commentedon Oct 3, 2018
(Though I like the changed you linked; we can certainly merge that one right away.)
tomharmon commentedon Feb 3, 2020
To add to this issue: Specifically we should use nom's
VerboseErrorto improve error messages. One thing pointed out by @spazm is that insrc/create.rs, thecreationfunction, might want to through a nom error with descriptive error message rather than the existingassert!(table.alias.is_none())