镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Fix Dependency Resolution Issues, Enhance Compatibility Checks, and Add Dockerfile - #118

Closed
SermetPekin wants to merge 53 commits into
ms609:masterfrom
SermetPekin:Rcpp_1.0.13
Closed

SermetPekin wants to merge 53 commits into
ms609:masterfrom
SermetPekin:Rcpp_1.0.13

Conversation

@SermetPekin

Copy link
Copy Markdown
Contributor

Summary

This PR addresses an error related to package resolution which was caused by dependencies of dependencies. Specifically, some packages required by our package were dependent on other packages which caused conflicts or issues during installation.

Changes Made

  1. Created a Dockerfile:

    • Base Image: Switched to rocker/r-ver:4.3.0 for consistency and compatibility.
    • System Dependencies: Added necessary system dependencies to support package installations.
    • R Packages Installation:
      • Installed essential R packages (devtools, remotes, pak, covr, testthat).
      • Installed the latest version of Rcpp from GitHub to ensure compatibility with the latest features.
      • Explicitly installed Matrix to resolve dependencies required by fGarch.
      • Installed all other dependencies (fGarch, univariateML, kdensity, TreeDistData, TreeDist, phangorn).
    • Testing: Included a step to run tests using devtools::test() to ensure the package and its dependencies are functioning correctly.
  2. Updated GitHub Actions Workflow:

    • Matrix Configuration: Ensured that tests are run on multiple operating systems and R versions, including R 3.4.0.
    • Dependencies Installation: Added steps to install devtools and remotes packages before using them to install other dependencies.

How These Changes Address the Issue

  • Dependency Resolution: By explicitly installing Matrix and other critical dependencies in the correct order, we prevent issues related to missing or conflicting dependencies.

  • Testing: Running tests during both the Docker build process and the CI workflow ensures that any issues with package functionality or compatibility are caught early.

  • Code Coverage: Including code coverage reporting helps maintain high code quality and ensures that all parts of the package are tested.

@ms609

ms609 commented Jun 27, 2024

Copy link
Copy Markdown
Owner

Closing as redundant to #119

@ms609 ms609 closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants