Repository navigation
Fix Dependency Resolution Issues, Enhance Compatibility Checks, and Add Dockerfile - #118
Closed
SermetPekin wants to merge 53 commits into
Closed
SermetPekin wants to merge 53 commits into
SermetPekin wants to merge 53 commits into
Conversation
3 of 4 tasks
Owner
|
Closing as redundant to #119 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses an error related to package resolution which was caused by dependencies of dependencies. Specifically, some packages required by our package were dependent on other packages which caused conflicts or issues during installation.
Changes Made
Created a Dockerfile:
rocker/r-ver:4.3.0for consistency and compatibility.devtools,remotes,pak,covr,testthat).Rcppfrom GitHub to ensure compatibility with the latest features.Matrixto resolve dependencies required byfGarch.fGarch,univariateML,kdensity,TreeDistData,TreeDist,phangorn).devtools::test()to ensure the package and its dependencies are functioning correctly.Updated GitHub Actions Workflow:
devtoolsandremotespackages before using them to install other dependencies.How These Changes Address the Issue
Dependency Resolution: By explicitly installing
Matrixand other critical dependencies in the correct order, we prevent issues related to missing or conflicting dependencies.Testing: Running tests during both the Docker build process and the CI workflow ensures that any issues with package functionality or compatibility are caught early.
Code Coverage: Including code coverage reporting helps maintain high code quality and ensures that all parts of the package are tested.