Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1026.
JSDOMParser keeps the lang attribute, but its elements have no lang property. For
<html lang="en">,document.documentElement.langreturnsundefined. Assigning.langalso leaves the attribute unchanged.Add a getter and setter using the existing attribute-accessor pattern. Missing and empty values return an empty string. Attribute changes and property changes stay in sync, including on created elements. Readability's article language extraction is unchanged.
Add regression tests for present, missing and empty values, case preservation, attribute updates/removal, child elements and serialization. Add an Unreleased changelog entry.
Related earlier work: #1028, which was withdrawn.
Validation on Windows/Node v24.13.1:
npm testpasses all 1,991 tests;npm run lintpasses. The seven new cases fail before the accessor is added. An independent comparison with the locked jsdom dependency passes all twelve checks after the fix.AI assistance: Codex helped prepare the code and tests.