Repository navigation
Conversation
Uh oh! Looks like an error!Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes: This request requires the client to satisfy the following scope expression:
|
badboy
left a comment
There was a problem hiding this comment.
This all looks pretty simple for now.
I'm not 100% sure I understand yet how it ends up being used, but that shouldn't be a blocker. It's unused, so we could land it and expand from there.
See some inline questions.
Please rebase to get CI running on it again.
| pub(crate) fn new(definitions: &[FlowDefinition]) -> Self { | ||
| let mut definitions: Vec<&FlowDefinition> = definitions.iter().collect(); |
There was a problem hiding this comment.
If this unconditionally collects the definitions into an owned vec here anyway, can we just take in a Vec<FlowDefinition>? Or does complicate the callers?
| for (i, definition) in definitions.into_iter().enumerate() { | ||
| let id = FlowId(i); | ||
| flows.push(RegisteredFlow { | ||
| name: definition.name.clone(), |
There was a problem hiding this comment.
Above could even save us more allocations, given we can probably avoid the clones down here (though overall that might all not be too relevant, given this is a one-time cost at init)
No description provided.