镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Bug 2077136 - Load flow registration into glean-core at init and build the event-to-flow index - #3693

Open
travis79 wants to merge 2 commits into
mainfrom
Bug2077136
Open

travis79 wants to merge 2 commits into
mainfrom
Bug2077136

Conversation

@travis79

Copy link
Copy Markdown
Member

No description provided.

@travis79
travis79 requested a review from a team as a code owner October 16, 2026 14:46
@travis79
travis79 requested review from badboy and removed request for a team October 16, 2026 14:46
@firefoxci-taskcluster

Copy link
Copy Markdown
Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:glean-level-1/Tb9aGPHXQfqhuWotO1BpYA/N2cN6EJ5TgaBiYjshYVA7A",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:glean-level-1/Tb9aGPHXQfqhuWotO1BpYA"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:glean-level-1/Tb9aGPHXQfqhuWotO1BpYA/N2cN6EJ5TgaBiYjshYVA7A",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:glean-level-1/Tb9aGPHXQfqhuWotO1BpYA"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2026-10-16T17:51:54.189Z

@badboy badboy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks pretty simple for now.
I'm not 100% sure I understand yet how it ends up being used, but that shouldn't be a blocker. It's unused, so we could land it and expand from there.

See some inline questions.
Please rebase to get CI running on it again.

Comment on lines +91 to +92
pub(crate) fn new(definitions: &[FlowDefinition]) -> Self {
let mut definitions: Vec<&FlowDefinition> = definitions.iter().collect();

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this unconditionally collects the definitions into an owned vec here anyway, can we just take in a Vec<FlowDefinition>? Or does complicate the callers?

for (i, definition) in definitions.into_iter().enumerate() {
let id = FlowId(i);
flows.push(RegisteredFlow {
name: definition.name.clone(),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above could even save us more allocations, given we can probably avoid the clones down here (though overall that might all not be too relevant, given this is a one-time cost at init)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants