Repository navigation
Replace category/name split with a single identifier (and save on some adhoc allocations hopefully) - #3684
Open
badboy wants to merge 1 commit into
Open
Replace category/name split with a single identifier (and save on some adhoc allocations hopefully)#3684badboy wants to merge 1 commit into
badboy wants to merge 1 commit into
Conversation
badboy
added this pull request to stack #3685
October 13, 2026 09:24
Member
Author
|
parser: mozilla/glean_parser#864 |
badboy
force-pushed
the
less-formatting-for-sqlite-too/ywmlnsvvyymx
branch
from
October 20, 2026 10:01
4142f14 to
3bf824d
Compare
badboy
force-pushed
the
less-formatting-for-sqlite-too/ywmlnsvvyymx
branch
from
October 20, 2026 10:49
3bf824d to
e6734a6
Compare
badboy
force-pushed
the
less-formatting-for-sqlite-too/ywmlnsvvyymx
branch
from
October 20, 2026 11:11
e6734a6 to
e0b60a6
Compare
…e adhoc allocations hopefully)
badboy
force-pushed
the
less-formatting-for-sqlite-too/ywmlnsvvyymx
branch
from
October 22, 2026 15:27
e0b60a6 to
996206b
Compare
badboy
marked this pull request as ready for review
October 22, 2026 15:27
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is replacing the category/name split everywhere with just a single identifier.
This is a MAJOR BREAKING CHANGE and will require glean_parser changes as well.
I argue this is very useful:
Stringand.into()calls in generated templates)