镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Replace uint with unsigned int for MSVC compatibility - #762

Open
iamnambiar wants to merge 1 commit into
moveit:ros2from
iamnambiar:fix/msvc-uint
Open

iamnambiar wants to merge 1 commit into
moveit:ros2from
iamnambiar:fix/msvc-uint

Conversation

@iamnambiar

@iamnambiar iamnambiar commented Oct 25, 2026 •

Copy link
Copy Markdown

uint is not a standard C++ type. It's only defined by glibc's <sys/types.h>, so it isn't available on MSVC. This PR replaces every use of uint as a type with unsigned int

Summary by CodeRabbit

  • Refactor
    • Updated numeric type declarations across planning, solution introspection, and task visualization interfaces.
    • Existing planning behavior, default values, solution lookups, and displayed information remain unchanged.

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d6320545-1cdc-41fc-bc66-9fd796c3096e
Commits

Reviewing files that changed from the base of the PR and between f527048 and 3c12f79.

Files selected for processing: 12
  • core/include/moveit/task_constructor/introspection.h
  • core/include/moveit/task_constructor/properties.h
  • core/python/bindings/src/solvers.cpp
  • core/src/introspection.cpp
  • core/src/solvers/pipeline_planner.cpp
  • core/src/stages/generate_place_pose.cpp
  • core/test/test_stage.cpp
  • visualization/motion_planning_tasks/src/local_task_model.cpp
  • visualization/motion_planning_tasks/src/remote_task_model.cpp
  • visualization/motion_planning_tasks/src/remote_task_model.h
  • visualization/motion_planning_tasks/src/task_panel.cpp
  • visualization/motion_planning_tasks/test/test_task_model.cpp

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Walkthrough

The pull request replaces uint with unsigned int across core APIs, planner properties, pose-generation counters, visualization models, and tests. Existing lookup behavior, defaults, and Python property names remain unchanged.

Changes: Unsigned integer type updates

Layer / File(s) Summary
Core declarations and use
core/include/moveit/task_constructor/*, core/python/bindings/src/solvers.cpp, core/src/introspection.cpp, core/src/solvers/pipeline_planner.cpp, core/src/stages/generate_place_pose.cpp, core/test/test_stage.cpp
Core APIs, planner properties, pose-generation counters, and a stage test use unsigned int instead of uint. The planner default and existing lookup behavior are unchanged.
Visualization model and counters
visualization/motion_planning_tasks/src/*, visualization/motion_planning_tasks/test/test_task_model.cpp
Visualization model return types, counters, and test identifiers use unsigned int instead of uint.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Refactor

Suggested reviewers: rhaschke

Merge Risk: Minimal · up to 3c12f

No actionable merge-blocking risk was identified.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 11.11% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 18 functions across 12 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly and concisely describes the main change: replacing the non-standard uint type with unsigned int to improve MSVC compatibility.
Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@iamnambiar iamnambiar changed the title Replace uint with unsigned int Replace uint with unsigned int for MSVC compatibility Oct 26, 2026

@rhaschke rhaschke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the format changes requested by clang-format.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants