Repository navigation
Replace uint with unsigned int for MSVC compatibility - #762
iamnambiar wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Core declarations and use core/include/moveit/task_constructor/*, core/python/bindings/src/solvers.cpp, core/src/introspection.cpp, core/src/solvers/pipeline_planner.cpp, core/src/stages/generate_place_pose.cpp, core/test/test_stage.cpp |
Core APIs, planner properties, pose-generation counters, and a stage test use unsigned int instead of uint. The planner default and existing lookup behavior are unchanged. |
Visualization model and counters visualization/motion_planning_tasks/src/*, visualization/motion_planning_tasks/test/test_task_model.cpp |
Visualization model return types, counters, and test identifiers use unsigned int instead of uint. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Refactor
Suggested reviewers: rhaschke
Merge Risk: 
Minimal · up to 3c12f
-
No actionable merge-blocking risk was identified.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passed -
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
rhaschke
left a comment
There was a problem hiding this comment.
Please apply the format changes requested by clang-format.
uint is not a standard C++ type. It's only defined by glibc's <sys/types.h>, so it isn't available on MSVC. This PR replaces every use of uint as a type with unsigned int
Summary by CodeRabbit