Repository navigation
fix: issue #902 — login rate limit reads ms3_customer_max_login_attempts & ms3_customer_block_duration - #1017
Open
Ibochkarev wants to merge 1 commit into
Open
Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
…ttempts and ms3_customer_block_duration settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: issue #902 — login rate limit now respects system settings
Problem
The
Loginprocessor used hard‑coded limits (maxAttempts = 5, windowSeconds = 300). These values ignored the configurable settingsms3_customer_max_login_attemptsandms3_customer_block_duration, making it impossible for site owners to adjust the brute‑force protection thresholds.Fix
core/components/minishop3/src/Processors/Api/Customer/Login.phpto read the two settings via$this->modx->getOption().Related issue
Testing
fix/902-login-rate-limit-reads-settingsto theproject.testenvironment.ms3_customer_max_login_attemptsto a custom value (e.g., 3) andms3_customer_block_durationto 120.composer test). All tests pass.Changelog
Branch:
fix/902-login-rate-limit-reads-settingsBase:
beta