Repository navigation
FIX: Correct EM covariance and BCD acceleration in mxne_optim - #14371
Open
FolatheDuckofDuckingburg wants to merge 2 commits into
Open
FolatheDuckofDuckingburg wants to merge 2 commits into
FolatheDuckofDuckingburg wants to merge 2 commits into
Conversation
FolatheDuckofDuckingburg
commented
Oct 3, 2026
- I wrote the code; I just asked DeepSeek to debug it.
Member
|
These changes are quite extensive, and really I'm not totally sure how to review and evaluate it. Would it be worth breaking up into a couple or few smaller PRs that fix one aspect at a time? +535 -1118 is pretty big. |
Author
|
Sure! I don't see why not! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.