PageIterator is using getDeclaredMethods instead of getMethods. If inheritance is used wrong way of returning oDataNextLink is used

Expected behavior

List of all groups belonging to a user

Actual behavior

First page of 100 groups returned

Steps to reproduce the behavior

        List<String> lst = new ArrayList<>();
        GroupCollectionResponse user = graphServiceClient.users().byUserId("xxxx_xxxxx@xxxx.com").memberOf().graphGroup().get();
        PageIterator iterator = new PageIterator.Builder<Group, GroupCollectionResponse>()
                .client(graphServiceClient)
                .collectionPage(user)
                .collectionPageFactory(GroupCollectionResponse::createFromDiscriminatorValue)
                .processPageItemCallback(group -> {
                    System.out.println(group.getDisplayName());
                    lst.add(group.getDisplayName());
                    return true;
                })
                .build();
        iterator.iterate();
        System.out.println(lst.size());

JozefDropco

Hi JozefDropco
Can you confirm which version of the SDK you are using?

Vincent Biret (@baywet)

Hi Vincent Biret (@baywet) my mother-in-law died, I will ask my collegue to find this information or I will update you once I am again working.

I'm sorry for your loss. Please take the time you need

michalchotvac (@MichalChotvac)

michalchotvac (@MichalChotvac) following up from my comment here microsoftgraph/msgraph-sdk-java#1784

The faulty code that this issue author's was mentioning is located here

msgraph-sdk-java-core/src/main/java/com/microsoft/graph/core/tasks/PageIterator.java

Line 305 in 62d6deb

Method[] methods = parsableCollection.getClass().getDeclaredMethods();

Would you be willing/able to submit a pull request to address the issue?

Vincent Biret (@baywet)

Hello Vincent Biret (@baywet) , Ramses Sanchez-Hernandez (@ramsessanchez) can you please submit a pull request to address the issue as I can see the issue is assigned to you, it will be much faster :)

Vincent Biret (@baywet)

Hello Vincent Biret (@baywet) , after replacing the

.getDeclaredMethods()

with

.getMethods()

and publishing it locally, I got following error:

java.lang.ReflectiveOperationException: Could not extract nextLink from parsableCollection.
	at com.microsoft.graph.core.tasks.PageIterator.extractNextLinkFromParsable(PageIterator.java:314)
	at com.microsoft.graph.core.tasks.PageIterator.intrapageIterate(PageIterator.java:223)
	at com.microsoft.graph.core.tasks.PageIterator.iterate(PageIterator.java:270)

Can you please check?

Philip Gichuhi (@Ndiritu)

Hi,
Unfortunately we're a bit short-handed here.
But Philip Gichuhi (@Ndiritu) took over this bug and we can expect to have a fix during the next week.
Thank you for your patience.

Navigation Menu

Repository navigation

PageIterator is using getDeclaredMethods instead of getMethods. If inheritance is used wrong way of returning oDataNextLink is used #1452

Expected behavior

Actual behavior

Steps to reproduce the behavior

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

PageIterator is using getDeclaredMethods instead of getMethods. If inheritance is used wrong way of returning oDataNextLink is used #1452

Description

Expected behavior

Actual behavior

Steps to reproduce the behavior

Activity

baywet commented on Feb 8, 2024

JozefDropco commented on Feb 8, 2024

baywet commented on Feb 8, 2024

baywet commented on Feb 8, 2024

MichalChotvac commented on Feb 8, 2024

MichalChotvac commented on Feb 9, 2024

baywet commented on Feb 9, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions