This repository was archived by the owner on Jan 29, 2026. It is now read-only.
Repository navigation
Code cleanup - #316
Merged
Mingxin Wang (mingxwa) merged 4 commits intoJun 18, 2025
Merged
Code cleanup#316
Conversation
Mingxin Wang (mingxwa)
requested review from
Kenny Guo (guominrui) and
Tian L. (tian-lt)
June 18, 2025 02:22
Kenny Guo (guominrui)
approved these changes
Jun 18, 2025
Tian L. (tian-lt)
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
std::construct_at(this, ...)andstd::destroy_at(this)inproxywith private function calls. Otherwise, UB is inevitable (likereset()), although it passes unit tests.details::invocation_metaandmeta_ptr_indirect_implas they are no longer required.