Repository navigation
release: use correct ESRP param name in tasks - #1002
Merged
Merged
Conversation
Use the correct parameter name for the ESRP app connection in the 'prereq' ESRP task. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
Matthew John Cheetham (mjcheetham)
enabled auto-merge
October 12, 2026 12:16
Johannes Schindelin (dscho)
approved these changes
Oct 12, 2026
Johannes Schindelin (dscho)
left a comment
Member
There was a problem hiding this comment.
This should probably be merged before #1001, as that PR seems to be stacked on this one.
Matthew John Cheetham (mjcheetham)
merged commit Oct 12, 2026
9dfde46
into
vfs-2.56.0
152 of 153 checks passed
Matthew John Cheetham (mjcheetham)
added a commit
that referenced
this pull request
Oct 12, 2026
#1002 was incomplete.. this will fix it correctly (hopefully!). We need to use Bash not Powershell for this pre-req task since it runs on Linux, not Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the correct parameter name for the ESRP app connection in the 'prereq' ESRP task.