Repository navigation
Introduce copious amounts of TextBuffer tests - #980
Merged
Merged
Conversation
Dustin L. Howett (DHowett)
approved these changes
Oct 6, 2026
| } | ||
| } | ||
|
|
||
| #[track_caller] |
There was a problem hiding this comment.
I'm guessing based only on the name that this fixes one of my lease favorite parts of many C++ test frameworks: the check helper function being blamed for the failure.
Member
Author
There was a problem hiding this comment.
Yep. It causes the caller context to be blamed for the assertion failure.
Leonard Hecker (lhecker)
enabled auto-merge (squash)
October 6, 2026 21:24
Leonard Hecker (lhecker)
disabled auto-merge
October 6, 2026 21:24
Leonard Hecker (lhecker)
enabled auto-merge (squash)
October 6, 2026 21:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for commit 6118429.