镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Make JSDoc parsing slow again for perf testing - #56987

Closed
Jake Bailey (jakebailey) wants to merge 1 commit into
microsoft:mainfrom
jakebailey:dummy-change-slow-jsdoc
Closed

Jake Bailey (jakebailey) wants to merge 1 commit into
microsoft:mainfrom
jakebailey:dummy-change-slow-jsdoc

Conversation

@jakebailey

Copy link
Copy Markdown
Member

Just a quick check to force JSDoc parsing again to test new perf stuff.

@jakebailey

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) perf test public

@typescript-bot

TypeScript Bot (typescript-bot) commented Jan 8, 2024 •

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the public perf test suite on this PR at 2a591bd. You can monitor the build here.

Update: The results are in!

@typescript-bot

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
self-build-src - node (v20.5.1, x64)
Memory used 2,671,718k (± 2.85%) 2,745,752k (± 2.77%) ~ 2,696,062k 2,844,619k p=0.810 n=6
Parse Time 5.03s (± 1.41%) 5.74s (± 1.04%) 🔻+0.71s (+14.12%) 5.67s 5.82s p=0.005 n=6
Bind Time 2.01s (± 1.23%) 1.97s (± 5.13%) ~ 1.84s 2.08s p=0.688 n=6
Check Time 31.99s (± 0.50%) 32.54s (± 0.80%) +0.55s (+ 1.70%) 32.30s 32.99s p=0.005 n=6
Emit Time 2.82s (± 1.28%) 2.77s (± 1.92%) ~ 2.68s 2.82s p=0.090 n=6
Total Time 41.87s (± 0.38%) 43.02s (± 0.57%) +1.15s (+ 2.75%) 42.75s 43.38s p=0.005 n=6
self-compiler - node (v20.5.1, x64)
Memory used 418,687k (± 0.02%) 427,351k (± 0.01%) +8,664k (+ 2.07%) 427,296k 427,427k p=0.005 n=6
Parse Time 2.88s (± 0.42%) 3.17s (± 0.13%) 🔻+0.28s (+ 9.88%) 3.16s 3.17s p=0.004 n=6
Bind Time 1.14s (± 1.03%) 1.14s (± 0.36%) ~ 1.13s 1.14s p=0.584 n=6
Check Time 14.07s (± 0.11%) 14.18s (± 0.33%) +0.11s (+ 0.77%) 14.13s 14.24s p=0.005 n=6
Emit Time 1.05s (± 1.20%) 1.04s (± 1.12%) ~ 1.02s 1.05s p=0.498 n=6
Total Time 19.14s (± 0.12%) 19.53s (± 0.24%) +0.38s (+ 1.99%) 19.47s 19.59s p=0.005 n=6
vscode - node (v20.5.1, x64)
Memory used 2,827,941k (± 0.00%) 2,844,647k (± 0.01%) +16,705k (+ 0.59%) 2,844,438k 2,844,770k p=0.005 n=6
Parse Time 10.72s (± 0.19%) 11.27s (± 0.58%) 🔻+0.54s (+ 5.07%) 11.16s 11.36s p=0.005 n=6
Bind Time 3.43s (± 0.34%) 3.45s (± 0.30%) +0.03s (+ 0.73%) 3.44s 3.47s p=0.007 n=6
Check Time 55.97s (± 0.36%) 56.58s (± 0.49%) +0.61s (+ 1.08%) 56.21s 56.88s p=0.008 n=6
Emit Time 16.22s (± 0.39%) 17.40s (±10.75%) ~ 16.11s 19.88s p=0.378 n=6
Total Time 86.34s (± 0.27%) 88.70s (± 1.88%) +2.36s (+ 2.73%) 87.32s 90.99s p=0.005 n=6
System info unknown
Hosts
  • node (v20.5.1, x64)
Scenarios
  • self-build-src - node (v20.5.1, x64)
  • self-compiler - node (v20.5.1, x64)
  • vscode - node (v20.5.1, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@jakebailey
Jake Bailey (jakebailey) deleted the dummy-change-slow-jsdoc branch January 8, 2024 23:30
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants