Repository navigation
isDeclarationName: support ComputedPropertyName - #22123
Merged
2 commits merged intoFeb 22, 2018
Merged
2 commits merged into
2 commits merged into
Conversation
ghost
requested review from
Ron Buckton (rbuckton) and
Wesley Wigham (weswigham)
February 22, 2018 18:23
ghost
force-pushed
the
computed_property_is_declaration_name
branch
from
February 22, 2018 18:23
d15c75a to
85a87ac
Compare
ghost
requested a review
from Nathan Shively-Sanders (sandersn)
February 22, 2018 18:23
Nathan Shively-Sanders (sandersn)
approved these changes
Feb 22, 2018
Mohamed Hegazy (mhegazy)
approved these changes
Feb 22, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of #15473 we should be getting symbols on computed property names, so we might as well include those in our baselines.
Also note the
symbolProperty24.errors.txtchange, which required changing asymbol.escapedNameuse tosymbolToString(#21009).