Repository navigation
Narrow readonly properties of const locals in function expressions - #10015
Closed
Nathan Shively-Sanders (sandersn) wants to merge 5 commits into
Closed
Nathan Shively-Sanders (sandersn) wants to merge 5 commits into
Nathan Shively-Sanders (sandersn) wants to merge 5 commits into
Conversation
| return propType; | ||
| } | ||
| return getFlowTypeOfReference(node, propType, /*assumeInitialized*/ true, /*includeOuterFunctions*/ false); | ||
| return getFlowTypeOfReference(node, propType, /*assumeInitialized*/ true, /*includeOuterFunctions*/ isReadonlySymbol(prop)); |
There was a problem hiding this comment.
I think you need a stronger check here. Say that you have a property access for x.y.z. Right now you're just checking whether z is a readonly symbol, but you really need to check for x.y and x as well.
Contributor
|
Nathan Shively-Sanders (@sandersn) can you refresh this PR. |
…-in-function-expressions
…-in-function-expressions
Member
Author
|
I refreshed the PR, but it still doesn't check parent properties for |
Mohamed Hegazy (mhegazy)
deleted the
narrow-readonly-properties-of-const-locals-in-function-expressions
branch
November 2, 2017 21:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9511
Anders Hejlsberg (@ahejlsberg) do you think this is a good change? It looks OK to me, but I don't have a good intuition for which narrowings are safe and which are not.