Repository navigation
getSourceFilePathInNewDir broken by recent commits #9768
Description
TypeScript Version: 2.0.0-beta
Zhengbo Li (@zhengbli) The following commit appears to have broken the getSourceFilePathInNewDir implementation in certain circumstances:
The use of getCanonicalFileName breaks the implementation if the common directory is a parent of the current directory.
For example, with these files:
C:/Users/Nicholas/example/a/a.ts
C:/Users/Nicholas/example/b/b.ts
The common directory is C:/Users/Nicholas/example.
If the current directory is C:/Users/Nicholas/example/b, for the a.ts source file:
cannonical source = ../a/a.ts
cannonical common = ..
So isSourceFileInCommonSourceDirectory will be true.
However, for the b.ts source file:
cannonical source = b.ts
cannonical common = ..
So isSourceFileInCommonSourceDirectory will be false - which will result in the absolute path to the source file - C:/Users/Nicholas/example/b/b.ts - being returned.
Specifically, this change to the implementation breaks my tsify-based builds.
Activity
zhengbli commentedon Aug 3, 2016
I don't quite understand. The
sourceFilePathis always an absolute path returned bygetNormalizedAbsolutePath, andgetCanonicalFileNameonly changes casing, so why does the cannonical source file path ofC:/Users/Nicholas/example/b/b.tsbecomeb.ts?cartant commentedon Aug 3, 2016
getCanonicalFileNamedoes more than change the case; it returns a relative path. And ifC:/Users/Nicholas/example/bis the current directory,b.tsis the cannonical path. The examples I gave were from console outputs I placed in the source - with some upper directory levels removed.cartant commentedon Aug 3, 2016
I think I see the problem.
getCanonicalFileNameis implemented in the host, so it'stsify's implementation that's being called. It's not calling the TypeScript implementation ofgetCanonicalFileName- which, as you've said, just changes the case.Thanks. I guess I have something to fix in
tsify.