镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Symbols as literal types #7436

Description

@Ciantic

Consider following use case for string literals at the moment in Flux:

interface IAction {
    actionType: string
}
interface ISayHelloAction extends IAction {
    actionType: "SAY_HELLO";
}

// Somewhere in your code you check that the message is ISayHelloAction from that actionType string using normal if

function processActions(action: IAction|ISayHelloAction|...) {
    if (action.actionType === "SAY_HELLO") {
        // action is ISayHelloAction
    }
}

(Above example assumes #6028 gets fixed, for the moment one can implement own type guard.)

But it would be even better if one could use Symbol for the same thing:

interface IAction {
    actionType: Symbol
}
const SAY_HELLO: Symbol = Symbol();

interface ISayHelloAction extends IAction {
    actionType: SAY_HELLO; // "Symbol literal type"
}

function processActions(action: IAction|ISayHelloAction|...) {
    if (action.actionType === SAY_HELLO) {
        // ... is ISayHelloAction
    }
}

These symbol literal types has same type guard requirement as literal types.

Activity

  1. yortus commented on Mar 9, 2016

    @yortus
    Contributor

    FYI there is some previous discussion about symbols as literal types starting here.

  2. added
    SuggestionAn idea for TypeScript
    Needs ProposalThis issue needs a plan that clarifies the finer details of how it could be implemented.
    on Mar 9, 2016
  3. Artazor commented on Mar 14, 2016

    @Artazor
    Contributor

    Would be useful.

  4. mnpenner commented on Jun 19, 2017

    @mnpenner

    Here's another example where this would be useful:

    export const __skip__ = Symbol('skip');
    
    function filterMapArray<ValueType,ReturnType>(iterable: Iterable<ValueType>, callback: (v: ValueType, k: number) => ReturnType|symbol): ReturnType[] {
        let accum = [];
    
        let i = 0;
        for(let x of iterable) {
            let y = callback(x, i++);
            if(y !== __skip__) {
                accum.push(y);
            }
        }
    
        return accum; // TS2322: Type '(symbol | ReturnType)[]' is not assignable to type 'ReturnType[]'.
      Type 'symbol | ReturnType' is not assignable to type 'ReturnType'. Type 'symbol' is not assignable to type 'ReturnType'.
    }

    This code won't compile because I can only typehint against symbol, but not __skip__. TS can't determine that accum contains only ReturnTypes.

  5. locked and limited conversation to collaborators on Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Needs ProposalThis issue needs a plan that clarifies the finer details of how it could be implemented.SuggestionAn idea for TypeScript

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions