Repository navigation
Problem with .d.ts file generation for inner classes #59079
Description
For the situations where the sub-class should return itself in the callback, it generates the wrong type.
It also generates a duplicate definition.
class Test {
static Builder = class {
static Create() {
return new this();
}
PrintHello() {
return this;
}
PrintGoodbye() {
return this;
}
GetNumber() {
return 5;
}
};
Method1(){
console.log("1");
return this
}
}expected behaviour
generates .d.ts like/ or something like
declare class Anonymous1 {
static Create(): Anonymous1
PrintHello(): this;
PrintGoodbye(): this;
GetNumber(): number;
}
declare class Test {
static Builder: Anonymous1;
Method1(): this;
}got
declare class Test {
static Builder: {
new (): {
PrintHello(): any;
PrintGoodbye(): any;
GetNumber(): number;
};
Create(): {
PrintHello(): any;
PrintGoodbye(): any;
GetNumber(): number;
};
};
Method1(): this;
}Some of the tooling relies on the type generation e.g. roblox-ts
and it causes some problems with the package Intellisense because any cannot be used for the generation of code like luau
Activity
Velover commentedon Jun 30, 2024
i didn't add the duplicate label, it happened automatically
there are no duplicates of this...
fatcerberus commentedon Jun 30, 2024
It’s because you used the issue template for 9998 duplicates, this isn’t that (did the read the text in the template before you deleted it?). In fact there are no callback functions here
fatcerberus commentedon Jun 30, 2024
#52415 is very similar but not an exact duplicate.
See also #41587 which is probably what's needed to fix this.
Velover commentedon Jun 30, 2024
Is that a problem? If so can I fix it?
I just got a little confused with these templates and picked the one that was the closest to the issue
typescript-bot commentedon Jul 3, 2024
This issue has been marked as "Duplicate" and has seen no recent activity. It has been automatically closed for house-keeping purposes.