Repository navigation
triple-slash reference added only if another triple-slash reference exists #57482
Description
🔎 Search Terms
triple-slash reference added
🕗 Version & Regression Information
- This is the behavior in every version I tried
⏯ Playground Link
💻 Code
// @declaration: true
// @filename: /a/node_modules/extra/index.d.ts
interface Error2 {
stack2: string;
}
// @filename: /a/node_modules/something/index.d.ts
/// <reference types="extra" />
// ^ remove above and it will no directive will be added to app.d.ts
export function foo():Error2;
// @filename: /a/app.ts
// reference to extra will be added here if there exists another reference to extra
export function foo() {
return null! as Error2;
}🙁 Actual behavior
/// <reference types="extra" /> is added to app.d.ts only if another reference directive to extra already exists (in this example one from node_modules)
🙂 Expected behavior
/// <reference types="extra" /> is always added since extra is required for app.d.ts to be valid
Additional information about the issue
This was discovered while trying to understand reference directives in the context of isolated declarations.
Activity
dragomirtitian commentedon Feb 22, 2024
Andrew Branch (@andrewbranch) do you have any insight on if this behavior is intentional?
andrewbranch commentedon Feb 22, 2024
I feel like I recently stumbled across a piece of code that doesn’t add type reference directives if the types are found in
typeRoots, but I don’t remember exactly where that was, and it feels unjustifiable to me.dragomirtitian commentedon Feb 22, 2024
This seems to be intentional, but I still don't understand why:
Also
fileToDirectiveis populated from thehost(const resolvedTypeReferenceDirectives = host.getResolvedTypeReferenceDirectives();) andgetResolvedTypeReferenceDirectivesjust returns the cache of reference directives that were found while parsing the programSourceFiles.This code seems to be really old (2016 by Vladimir Matveev)