Repository navigation
Improve non-top-level import/export error, especially for JS #47076
Description
Activity
Isn’t
exportused inside namespaces too? So (2) should probably be “An export declaration can only be used at the top level of module or namespace.”Hey everyone, I'd like to take on this issue.
can I work on this issue?
Lokesh Digari (@lokicodedaily) sure, although you might want to co-ordinate with Vicente Soriano (@vicente-s).
Bruce Pascoe (@fatcerberus) Good point. I updated the Expected section.
Nathan Shively-Sanders (@sandersn)
I tried to fix it in #47087, but did I do something wrong in the PR procedure?
I would be grateful for any feedback.islandryu I'm backlogged on community PRs. I'll review it when I can.
Reacted by Omri LuzonReacted by islandryuThank you islandryu!
- locked as resolved and limited conversation to collaborators
on Oct 22, 2025
ES imports and exports can only be used at the top level of a module. This is illegal:
The current errors for these three statements are vague and, for JS, contain irrelevant terms:
Actual:
(1) "An import declaration can only be used in a namespace or module."
(2) "An export declaration can only be used in a module."
(3) "A namespace declaration is only allowed in a namespace or module."
Expected:
(1) When the node is in a JS file, "An import declaration can only be used at the top level of a module."
Otherwise, "An import declaration can only be used at the top level of a namespace or module."
(2) When the node is in a JS file, "An export declaration can only be used at the top level of a module."
Otherwise, "An export declaration can only be used at the top level of a namespace or module."
(3) "A namespace declaration is only allowed at the top level of a module."
Implementation:
checkGrammarModuleElementContextissues these errors. I don't know whether it's better to make it smarter or just avoid calling it for case (1).