Activity

1. ahejlsberg commented on Nov 4, 2021

   

   Anders Hejlsberg (ahejlsberg)

   on Nov 4, 2021

   Member

   More actions

   Yeah, might be nice to support. Though it's an expensive way to do it as you're incurring an extra object allocation.
2. lazytype commented on Nov 4, 2021

   

   lazytype

   on Nov 4, 2021

   Last edited by lazytype

   Author

   More actions

   Yep, but par for the course for contexts like React where you might extract some props and forward the rest

   import React from 'react'
   
   type Props =
     | ({ as: "div" } & React.ComponentPropsWithRef<"div">)
     | ({ as: "span" } & React.ComponentPropsWithRef<"span">)
   
   function Component({ as, ...rest }: Props) {
     if (as === 'div') {
       return <div {...rest} />
     }
     if (as === 'span') {
       return <span {...rest} />
     }
   
     // I think something like https://github.com/microsoft/TypeScript/issues/30581 would let us just do:
     // return <as {...rest} />
   }

   👍React with 👍4Reacted by Steven Luscher, Sébastien Lorber, João Ferreira and Onyedikachi Ozoani
3. andrewbranch commented on Nov 4, 2021

   

   Andrew Branch (andrewbranch)

   on Nov 4, 2021

   Member

   More actions

   Can confirm this looks like something React devs do

   👍React with 👍12Reacted by Sébastien Lorber, Mateus Vahl, Oleksandr Vinohradov, Sebastian Andil, jp2masa, Mike Holloway, Magoz, Fernando Greco, Steven Luscher, ortophius and 2 more

   😄React with 😄4Reacted by lazytype, Tiago Alves, ortophius and nvmnghia
4. Andrew Branch (andrewbranch)

   added

   In DiscussionNot yet reached consensusNot yet reached consensus

   SuggestionAn idea for TypeScriptAn idea for TypeScript

   on Nov 4, 2021
5. mhofman commented on Jan 29, 2022

   

   Mathieu Hofman (mhofman)

   on Jan 29, 2022

   More actions

   FYI, this is not only a React pattern, we would like to be able to write something like the following, based on #47190:

   type Message = {
    method: string,
    args: unknown[],
    result?: string,
   };
   type KernelDeliveryMessage = [tag: 'message', target: string, msg: Message];
   type KernelDeliveryNotify = [tag: 'notify', resolutions: string[] ];
   
   type KernelDeliveryObject = KernelDeliveryMessage | KernelDeliveryNotify;
   
   declare function translateMessage(target: string, msg: Message): any;
   declare function translateNotify(resolutions: string[]): any;
   
   type KernelDeliveryToVatDelivery = (...args: KernelDeliveryObject) => any;
   
   const kernelDeliveryToVatDelivery:KernelDeliveryToVatDelivery = (type,...args) => {
       switch (type) {
         case 'message':
           return translateMessage(...args);
         case 'notify':
           return translateNotify(...args);
         default:
           throw new Error(`unknown kernelDelivery.type ${type}`);
       }
   }

   Output

   "use strict";
   const kernelDeliveryToVatDelivery = (type, ...args) => {
       switch (type) {
           case 'message':
               return translateMessage(...args);
           case 'notify':
               return translateNotify(...args);
           default:
               throw new Error(`unknown kernelDelivery.type ${type}`);
       }
   };

   Compiler Options

   {
     "compilerOptions": {
       "strict": true,
       "noImplicitAny": true,
       "strictNullChecks": true,
       "strictFunctionTypes": true,
       "strictPropertyInitialization": true,
       "strictBindCallApply": true,
       "noImplicitThis": true,
       "noImplicitReturns": true,
       "alwaysStrict": true,
       "esModuleInterop": true,
       "declaration": true,
       "experimentalDecorators": true,
       "emitDecoratorMetadata": true,
       "target": "ES2017",
       "module": "ESNext",
       "moduleResolution": "node"
     }
   }

   Playground Link: Provided

   👍React with 👍9Reacted by Joe Calzaretta, Turadg Aleahmad, Trevor Hartman, Faisal Rahman, Magoz, Steven Luscher, ortophius, Ivo Todorov and nvmnghia
6. nicolas (nicosampler)

   added a commit that references this issue on Oct 30, 2023

   feat: v2.2 (#24)

   ...

   853d514