Repository navigation
libdom.d.ts changes of 4.4.x break WebRTC standard #46379
Description
lib Update (revert changes) Request
I tried to follow all those topics about the libdom.d.ts changes introduced in 4.4.x but i did miss a topic that encapsulates that the changes totally break the WebRTC standard.
I made a fork / Branch: https://github.com/JanFellner/TypeScript/tree/bugfix/CC-2424-revert-webrtc-related-changes-from-9d443b76
- to revert all RTC related changes to strip down and just show the WebRTC changes that have been made.
- to have the old lib.dom.d.old.ts which shows the embedded file before the changes made by Update LKG to enable improved narrowing in 4.4. #44842 / 9d443b7 in that branch
The changes are so massive that it takes some time to nail down what really is element of the current standard and what has been removed replaced improved.
Activity
fippo commentedon Oct 15, 2021
to me this looks like some legacy Edge IDL definitions were removed. Some of the names are shared between WebRTC and ORTC which seems to be the main cause here.
MartinJohns commentedon Oct 15, 2021
This is the wrong repository for DOM related changes. You're looking for: https://github.com/microsoft/TypeScript-DOM-lib-generator
JanFellner commentedon Oct 15, 2021
Martin Johns (@MartinJohns) can you give me a wider picture?
The changes that affect us were introduced in 4.4.x with a merge by Daniel Rosenwasser (@DanielRosenwasser) so even if the origin of the sources is a second library i need to mention that here (at least to have all other affected notified properly)
Whats your proposal. Just open a ticket in the second library and link them together?
Just add the issue to microsoft/TypeScript-DOM-lib-generator#1029
The problem is that the change is breaking a widely used standard....
I do actually also wonder that no one was complaining about this standard breaking in total so far, maybe i am missing something.
orta commentedon Oct 15, 2021
The DOM lib generator creates these .d.ts files directly from the spec pages and then uses tools like the db powering caniuse to determine if the API is used in more than one browser, and W3C systems for declaring deprecations. The 4.4 changes should be very closely aligned with the spec for WebRTC. It's likely that the API changes which affected you are either:
If you think we've missed something we're happy to take issues on the specifics in the linked repo 👍🏻
JanFellner commentedon Oct 20, 2021
Can someone guide me a bite more to understand that process (or point me to where it is described?)
-- automatically created
-- by another repo (link)
-- and this was the version of that repo when the stub was created)
orta commentedon Oct 20, 2021
The version table is in the README for https://github.com/microsoft/TypeScript-DOM-lib-generator - adding the version metadata into the file is a great idea I've added it to that repo microsoft/TypeScript-DOM-lib-generator#1181
typescript-bot commentedon Oct 22, 2021
This issue has been marked as 'Question' and has seen no recent activity. It has been automatically closed for house-keeping purposes. If you're still waiting on a response, questions are usually better suited to stackoverflow or the TypeScript Discord community.