Repository navigation
sourcemap off-by-one errors #4591
Description
(using version 1.6.0-dev.20150825, with --declaration --module CommonJS --target ES5)
For some typescript code inputs, the compiler creates invalid mapping entry, mapping characters from the compiled code to the line break character at the end of the source line.
Sometimes, the mapped character from the compiled code is itself non-existent in the compiled file, like the last character in the last line.
for example, this code:
class Product {}
export default Product;is compiled into this code:
var Product = (function () {
function Product() {
}
return Product;
})();
Object.defineProperty(exports, "__esModule", { value: true });
exports.default = Product;
//# sourceMappingURL=test.js.mapwith this source map:
{"version":3,"file":"test.js","sourceRoot":"","sources":["test.ts"],"names":["Product","Product.constructor"],"mappings":"AAAA;IAAAA;IAAeC,CAACA;IAADD,cAACA;AAADA,CAACA,AAAhB,IAAgB;AAChB;kBAAe,OAAO,CAAC"}here is a visualization of the mapping in the example above. Notice how locations 1:16 and 2:23 do not exist in the source file's text, as well as 6:26 in the compiled code.
Activity
mhegazy commentedon Sep 1, 2015
Sheetal Nandi (@sheetalkamat) can you take a look.
sheetalkamat commentedon Sep 8, 2015
Amir Arad (@amir-arad). while investigating this here are the mapping entries(note I converted them into 1 based while printing) for visualization as shown here
Note that
Represent name Product correctly in source and emitted file.
I am looking into fixing the encoded mappings of kind 1:16, 2:23 in source as you mentioned because theoretically It should instead be next line column 0 in source instead.
amir-arad commentedon Sep 24, 2015
Thank you.
What about the last mapping? in your entries, this line:
signifies the one-after-last character in destination code (just before //# sourceMappingURL) , mapped to the one-after-last character in source. any thoughts on that?
Add test for #4591
mhegazy commentedon Sep 29, 2016
This should be working as expected in latest.