noImplicitOverride reports in JS files with checkJs enabled, can only ts-ignore the line

Bug Report

🔎 Search Terms

override checkjs jsdoc

🕗 Version & Regression Information

This changed between versions 4.2 and 4.3

⏯ Playground Link

💻 Code

class Foo {
  method() {
    return 1234
  }
}

class Bar extends Foo {
  method() {
    return super.method() + 42;
  }
}

🙁 Actual behavior

In my projects, I set checkJs to enforce that our non-TS files also typecheck. We also use the noImplicitOverride rule.

But, if you try to create a class with method overrides in JS files, you get the override errors, even though there doesn't appear to be a way to silence them except via // @ts-ignore.

🙂 Expected behavior

noImplicitOverride is not reported in JS files (or, there's some JSDoc way to add it, like types can be).

You can add a JSDoc /** @override */ tag to get around this. The error message should be clearer in these cases.

A quick fix like the ones for inferring types would be nice. Right now, all that's suggested is to add an ignore. (Not sure if those go here or vscode.)

AFAIK, TypeScript does not have good enough tools to handle jsdoc/comments yet. It's hard to add a jsdoc tag to something if there's already exists leading comments.

Daniel Rosenwasser (@DanielRosenwasser)

The issue is labeled "Domain: Error Messages". What should be the expected error message?

/cc Daniel Rosenwasser (@DanielRosenwasser)

Nathan Shively-Sanders (@sandersn)

What should be the expected error message?

Nathan Shively-Sanders (@sandersn) might have opinions but

This member must have a leading JSDoc comment with an '@override' tag because it overrides a member in the base class 'Foo'.

TypeScript does not have good enough tools to handle jsdoc/comments yet. It's hard to add a jsdoc tag to something if there's already exists leading comments.

This is a good point. We would accept a PR that doesn't include a quick fix, but maybe Nathan also has some ideas there.

Here's a PR to try to add quickfix support in js file. https://github.com/Kingwl/TypeScript/pull/8/files.

It's hard to add a jsdoc tag to something if there's already exists leading comments.

I believe inferFromUsage has code for this.

Wenlu Wang (@Kingwl)

Wenlu Wang (@Kingwl) see if there's anything there you might be able to leverage for your current work, and let us know if you run into any issues.

Kevin Tan (@stkevintan)

I guess it's might helpful to Kevin Tan (@stkevintan).

Navigation Menu

Repository navigation

noImplicitOverride reports in JS files with checkJs enabled, can only ts-ignore the line #45591

Bug Report

🔎 Search Terms

🕗 Version & Regression Information

⏯ Playground Link

💻 Code

🙁 Actual behavior

🙂 Expected behavior

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

noImplicitOverride reports in JS files with checkJs enabled, can only ts-ignore the line #45591

Description

Bug Report

🔎 Search Terms

🕗 Version & Regression Information

⏯ Playground Link

💻 Code

🙁 Actual behavior

🙂 Expected behavior

Activity

DanielRosenwasser commented on Aug 27, 2021

jakebailey commented on Aug 27, 2021

Kingwl commented on Aug 27, 2021

a-tarasyuk commented on Aug 30, 2021

DanielRosenwasser commented on Aug 30, 2021

Kingwl commented on Aug 31, 2021

sandersn commented on Sep 3, 2021

DanielRosenwasser commented on Sep 3, 2021

Kingwl commented on Sep 4, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions