Repository navigation
!. after ?. should be warned #35071
Description
This is an anti-pattern on the current type system. And the compiler must not do quick fix so. !. after ?. is simply replaceable with ?. and should do so.
TypeScript Version: 3.7.x-dev.20191105
Search Terms:
Code
document.querySelector('_')!.textContent!.split('') // old code
document.querySelector('_')?.textContent!.split('') ?? 0 // string[]
document.querySelector('_')?.textContent?.split('') ?? 0 // string[] | 0Expected behavior:
document.querySelector('_')!.textContent!.split('') // old code
document.querySelector('_')?.textContent!.split('') ?? 0 // unsafe, warning
document.querySelector('_')?.textContent?.split('') ?? 0 // safeActual behavior:
document.querySelector('_')!.textContent!.split('') // old code
document.querySelector('_')?.textContent!.split('') ?? 0 // unsafe, no warning
document.querySelector('_')?.textContent?.split('') ?? 0 // safePlayground Link:
Related Issues:
Activity
kitsonk commentedon Nov 13, 2019
Isn't this a just linting rule? Whenever you use
!it is potentially unsafe. The compiler never warns, an error is an error.falsandtru commentedon Nov 13, 2019
When quick fix observes this rule, it is wasteful splitting.
RyanCavanaugh commentedon Nov 13, 2019
falsandtru (@falsandtru) some discussion about what exactly is different between this and #35025 would be nice
falsandtru commentedon Nov 13, 2019
This issue has meaning without adopting #35025 and meaningless if #35025 is adopted. So this issue and #35025 are in opposition. This is the definitive difference.