Missing error after spreading generic props into JSX

TypeScript Version: 3.2.2

Search Terms:

Code

type Component<P> = (props: P) => any;

const myHof = <ComposedComponentProps extends any>(
    ComposedComponent: Component<ComposedComponentProps>,
) => {
    type WrapperComponentProps = ComposedComponentProps & { myProp: string };
    declare const WrapperComponent: Component<WrapperComponentProps>;

    declare const props: ComposedComponentProps;

    // Expected no error, got none - good
    WrapperComponent({ ...props, myProp: '1000000' });
    // Expected error, got one - good
    WrapperComponent({ ...props, myProp: 1000000 });
}

However, when I try to do the same with React (.tsx):

import React from 'react';

const myHoc = <ComposedComponentProps extends any>(
    ComposedComponent: React.ComponentClass<ComposedComponentProps>,
) => {
    type WrapperComponentProps = ComposedComponentProps & { myProp: string };
    declare const WrapperComponent: React.ComponentClass<WrapperComponentProps>;

    declare const props: ComposedComponentProps;

    // Expected no error, got none - good
    <WrapperComponent {...props} myProp={'1000000'} />;
    // Expected error, but got none - bad!
    <WrapperComponent {...props} myProp={1000000} />;
};

Looks like the issue is caused by the extends any. As a workaround, use extends unknown (to which it should behave identically to) until we have a fix in, instead.

Aha, thanks. The reason I do the extends btw is because it's needed for arrow functions in .jsx/.tsx.

Oliver Joseph Ash (@OliverJAsh)

Oliver Joseph Ash (@OliverJAsh) A trailing comma on the type argument list should disambiguate as well.

Wesley Wigham (@weswigham)

Wesley Wigham (@weswigham) let's please merge at the start of the 3.9 branch

Navigation Menu

Repository navigation

Missing error after spreading generic props into JSX #29509

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Missing error after spreading generic props into JSX #29509

Description

Activity

weswigham commented on Jan 24, 2019

OliverJAsh commented on Jan 24, 2019

weswigham commented on Jan 24, 2019

RyanCavanaugh commented on Jan 23, 2020

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions