Repository navigation
Auto import completion entries still causing debug failure in resolveEntityName, getTargetOfExportAssignment with TS 3.1.3 #28149
Description
TypeScript Version: 3.1.3
This is reopening #27636 for TS 3.1.3. A few users on VS Code 1.28.2 using TypeScript 3.1.3 still seem to be hitting this: microsoft/vscode#61660, microsoft/vscode#61452
Nathan Shively-Sanders (@sandersn) Andy (Andrewkraft) (@Andy-MS) Daniel Rosenwasser (@DanielRosenwasser) Can you please just verify that this issued has been fully fixed in 3.1.3. If not, can we try getting the fix in for 3.1.4. I'll follow up with the users on the VS Code side to see if this is fixed in typescript@next
Activity
[-]Imports still failing with TS 3.1.3[/-][+]Imports still failing with TS 3.1.3 in resolveEntityName, getTargetOfExportAssignment[/+][-]Imports still failing with TS 3.1.3 in resolveEntityName, getTargetOfExportAssignment[/-][+]Auto import completion entries still causing debug failure in resolveEntityName, getTargetOfExportAssignment with TS 3.1.3 [/+]sandersn commentedon Oct 26, 2018
Andy (Andrewkraft) (@Andy-MS) can confirm, but I'm pretty sure this fix is ca6e2e7 (in #28008), which is not in 3.1.3. In fact, it is the reason we're doing 3.1.4, as far as I know.
mjbvz commentedon Oct 26, 2018
Ok, I'm seeing a different stack here than was original reported in #27471
Do these issues have the same root cause? Here's a new stack for reference:
jrmyio commentedon Oct 30, 2018
Tried 1.28.2 with 3.1.3 default didnt work
Tried 1.28.2 with workspace 3.1.3, didnt work
Tried 1.28.2 with workspace 3.1.4, didnt work
Tried 1.28.2 with workspace 3.1.2, didnt work
Tried 1.28.2 with workspace 3.1.1, didnt work
Tried 1.27.2 with custom 3.1.3, didnt work
Tried 1.27.2 with 3.0.3 default worked
Back to 1.28.2, with workspace 3.0.3, worked
djensen47 commentedon Oct 30, 2018
Hi, I was asked to post here.
I'm using VS Code 1.28.x and Auto Import is not working. I tried using typescript@next but it did not resolve the issue.
gcazaciuc commentedon Nov 1, 2018
Same issue as Dave Jensen (@djensen47) above. Same VSCode version(1.28.2), tried with TS 3.1.3, 3.1.5 and next but Auto import still not working. However, it works when i downgrade TS to 3.0.3.
Stack trace:
jrmyio commentedon Nov 1, 2018
Andy (Andrewkraft) (@Andy-MS) typescript@next did not solve it.
blikblum commentedon Nov 2, 2018
I get the following stack trace using typescript 3.2.
To trigger:
container15 remaining items
MadaraUchiha commentedon Dec 2, 2018
Howdy! Thanks for your work on this matter so far, I can see you've been battling it for a few months now.
Wanted to add to the log that I'm still affected by this as of vscode
And TypeScript version 3.2.1.
sandersn commentedon May 17, 2019
Matt Bierner (@mjbvz) Are you still seeing these errors?
Luiz Américo (@blikblum) I tried to follow your repro steps and couldn't find
containerin main.js, even after checking out the commit from October 20, 1c21a8c, which I guess is the one that was current when you found the crash originally.I found a declaration of 'container' in common/di.js by looking at the stack trace, but it doesn't crash anymore for me. Does it still crash for you?
blikblum commentedon May 18, 2019
It did not exists in main.js, to reproduce write yourself "cont" somewhere in main.js and try to invoke auto import. It should add the container import from di module.
I'm not with my dev machine. Will try to reproduce ASAP
blikblum commentedon May 19, 2019
Nathan Shively-Sanders (@sandersn) working fine now (vscode 1.34)