镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

Automatically generating getter and setter #12417

Closed
Closed
Automatically generating getter and setter#12417
Labels
Domain: LS: Refactoringse.g. extract to constant or function, rename symbolFixedA PR has been merged for this issueSuggestionAn idea for TypeScriptVS Code TrackedThere is a VS Code equivalent to this issue
Milestone
TypeScript 2.9

Description

@waderyan
Wade Anderson (waderyan)
opened on Nov 21, 2016

From user414 on April 24, 2016 12:39

I couldn't find this issue already existing. I was starting to make variable public just to avoid the setter/getter manual writing, I knew it was time to look for something. Luckily someone beat me to it

https://marketplace.visualstudio.com/items?itemName=DSKWRK.vscode-generate-getter-setter

perhaps this code can be integrated in the mainline, or use as a basis for this new functionality.

Copied from original issue: microsoft/vscode#5716

Activity

  1. Wade Anderson (waderyan)
    self-assigned this
    on Nov 21, 2016
  2. Wade Anderson (waderyan)
    added
    feature-request
    typescript
    code-actions
    on Nov 21, 2016

  3. waderyan commented on Nov 21, 2016

    @waderyan
    Wade Anderson (waderyan)
    on Nov 21, 2016
    Author

    From Dirk Bäumer (@dbaeumer) on November 15, 2016 19:0

    Wade Anderson (@waderyan) this should come from the TS team.

  4. Wade Anderson (waderyan)
    added
    VS Code TrackedThere is a VS Code equivalent to this issue
    and removed
    code-actions
    feature-request
    typescript
    on Nov 21, 2016
  5. Wade Anderson (waderyan)
    removed their assignment
    on Nov 21, 2016
  6. Mohamed Hegazy (mhegazy)
    added
    SuggestionAn idea for TypeScript
    Domain: LS: Refactoringse.g. extract to constant or function, rename symbol
    on Nov 21, 2016

  7. DrewLandgrave commented on Feb 3, 2017

    @DrewLandgrave
    Drew Landgrave (DrewLandgrave)
    on Feb 3, 2017

    Has there been any movement on this?

  8. arielalvarez88 commented on Jun 15, 2017

    @arielalvarez88
    Ariel Alvarez (arielalvarez88)
    on Jun 15, 2017

    +1, pretty please

  9. davidmach14 commented on Jun 15, 2017

    @davidmach14
    David Mach (davidmach14)
    on Jun 15, 2017

    +1 I'm surprised it's not yet done...

  10. JianboYan commented on Feb 22, 2018

    @JianboYan
    Ryan (JianboYan)
    on Feb 22, 2018

    +1 I'm surprised it's not yet done...

  11. Kingwl commented on Feb 22, 2018

    @Kingwl
    Wenlu Wang (Kingwl)
    on Feb 22, 2018
    Contributor

    should this issue for community milestone? Mohamed Hegazy (@mhegazy)

  12. Mohamed Hegazy (mhegazy)
    added this to the milestone on Feb 22, 2018

  13. mhegazy commented on Feb 22, 2018

    @mhegazy
    Mohamed Hegazy (mhegazy)
    on Feb 22, 2018
    Contributor

    got for it Wenlu Wang (@Kingwl)

  14. Mohamed Hegazy (mhegazy)
    added
    FixedA PR has been merged for this issue
    on Apr 3, 2018
  15. Mohamed Hegazy (mhegazy)
    modified the milestones: , TypeScript 2.9 on Apr 3, 2018
  16. ghost closed this as completedin #22143on Apr 10, 2018

  17. mhegazy commented on Apr 10, 2018

    @mhegazy
    Mohamed Hegazy (mhegazy)
    on Apr 10, 2018
    Contributor

    thanks Wenlu Wang (@Kingwl)!

  18. microsoft
    locked and limited conversation to collaborators on Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Domain: LS: Refactoringse.g. extract to constant or function, rename symbolFixedA PR has been merged for this issueSuggestionAn idea for TypeScriptVS Code TrackedThere is a VS Code equivalent to this issue

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions