element.style[key] = value throws implicit any error #11914

Activity

1. aluanhaddad commented on Oct 29, 2016

   

   Aluan Haddad (aluanhaddad)

   on Oct 29, 2016

   Contributor

   More actions

   This behavior is correct. Specifically, element.style is typed as a CSSStyleDeclaration which is declared in lib.dom.d.ts as

   interface CSSStyleDeclaration {
       [index: number]: string;
   }
2. akarzazi commented on Oct 30, 2016

   

   Adel KARZAZI (akarzazi)

   on Oct 30, 2016

   More actions

   From W3C : https://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSSStyleDeclaration

   
   // Introduced in DOM Level 2:
   interface CSSStyleDeclaration {
              attribute DOMString        cssText;
                                           // raises(DOMException) on setting
   
     DOMString          getPropertyValue(in DOMString propertyName);
     CSSValue           getPropertyCSSValue(in DOMString propertyName);
     DOMString          removeProperty(in DOMString propertyName)
                                           raises(DOMException);
     DOMString          getPropertyPriority(in DOMString propertyName);
     void               setProperty(in DOMString propertyName, 
                                    in DOMString value, 
                                    in DOMString priority)
                                           raises(DOMException);
     readonly attribute unsigned long    length;
     DOMString          item(in unsigned long index);
     readonly attribute CSSRule          parentRule;
   };
   

   There is no string indexer on CSSStyleDeclaration.
   The statement : div.style["position"] is a JavaScript alternative way to access the property div.style.position, which is not possible in TypeScript.
3. mhegazy commented on Oct 30, 2016

   

   Mohamed Hegazy (mhegazy)

   on Oct 30, 2016

   Contributor

   More actions

   The statement : div.style["position"] is a JavaScript alternative way to access the property div.style.position, which is not possible in TypeScript.

   This is not accurate. both div.style["position"] and div.style.position work as intended. both resolve to the same property and both have the type string.

   This is another manifestation of #7730 which is basically that:

   const position = "position";
   div.style[position] // should behave the same way as div.style["position"]
4. Mohamed Hegazy (mhegazy)

   added

   DuplicateAn existing issue was already createdAn existing issue was already created

   on Oct 30, 2016
5. mhegazy commented on Oct 30, 2016

   

   Mohamed Hegazy (mhegazy)

   on Oct 30, 2016

   Contributor

   More actions

   this should be handled correctelly when #11929 is merged in.
6. mhegazy commented on Oct 30, 2016

   

   Mohamed Hegazy (mhegazy)

   on Oct 30, 2016

   Contributor

   More actions

   closing in favor of #7730.
7. Mohamed Hegazy (mhegazy)

   closed this as completedon Oct 30, 2016
8. akarzazi commented on Oct 30, 2016

   

   Adel KARZAZI (akarzazi)

   on Oct 30, 2016

   More actions

   My bad, TypeScript seems to handle index notation fine as long as the parameter is a string literal !

   const div = document.getElementsByTagName('div')[0];
   var a = div.style['position']; // a is string|null;
   
9. microsoft

   locked and limited conversation to collaborators on Jun 19, 2018