Repository navigation
FIX: Report ERROR when every TAP branch crashed before a score - #4159
Merged
Roman Lutz (romanlutz) merged 3 commits intoNov 13, 2026
Merged
Conversation
Contributor
Author
|
Mohammed Abumtary (@Mohammed-AB) please don't post AI-generated validation dumps on other people's PRs. Nobody asked for it, it only repeats what the PR description and its tests already cover, and it adds noise for the maintainers who have to review this. If you find an actual problem with the change, leave a short comment pointing at it. |
- Set error_type on the all-branches-crashed ERROR result from the stored
"<kind>: <detail>" node error string, so AttackErrorSummary no longer
shows None for these results.
- Clarify the outcome reason ("N branches failed to execute") and pluralize.
- Update _create_failure_result_async's docstring summary to cover the
ERROR and UNDETERMINED outcomes it can return.
- Loosen the exact-string outcome_reason assertion and use a realistic
node error message; assert the derived error_type.
- Add PAIR-level tests pinning ERROR propagation (and FAILURE when no
branch errored), since PAIR inherits the fix from TAP.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Roman Lutz (romanlutz)
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When every TAP or PAIR branch hit an exception, the node errors were only stored on the pruned nodes, so the attack returned FAILURE with a 0.00 best score and looked exactly like a target that refused everything.
Now TAP keeps the node errors on its context, and when nothing was ever scored and at least one branch errored, it returns ERROR with the error count and the last error as the reason and sets error_message on the result. PAIR gets the same through TAP.
Runs where any branch was scored, including a scored depth followed by a depth where everything crashed, still return FAILURE, and so do runs where every branch was off-topic.
The two tests that asserted FAILURE for the all-crashed case now expect ERROR, and there are new scenario cases for the off-topic and crash-after-score paths. The changed tests fail on main and pass here.
Fixes #4154