Repository navigation
fix: Fixed bug where group folds and sample weights couldn't be used together - #1405
Merged
Li Jiang (thinkall) merged 3 commits intoFeb 15, 2025
Conversation
…in the same automl instance
Collaborator
Author
|
Hi Li Jiang (@thinkall), |
Merged
4 tasks
Li Jiang (thinkall)
approved these changes
Feb 13, 2025
Li Jiang (thinkall)
left a comment
Collaborator
There was a problem hiding this comment.
Thank you Daniel Grindrod (@dannycg1996) for the PR! LGTM.
4 tasks done
1 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Previously there was an error with using sample weights and group folds together (see related issue). This PR fixes that issue, and adds a test to ensure that this stays fixed in future. I also noticed that we were importing
numpytwice withintest_splits.py, so I removed the defunct import statement.Related issue number
Closes #1396
Checks