镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix: Fixed bug where group folds and sample weights couldn't be used together - #1405

Merged
Li Jiang (thinkall) merged 3 commits into
microsoft:mainfrom
Evotec-isRD:fix-group-fold-and-sample-weight-issue
Feb 15, 2025
Merged

Li Jiang (thinkall) merged 3 commits into
microsoft:mainfrom
Evotec-isRD:fix-group-fold-and-sample-weight-issue

Conversation

@dannycg1996

@dannycg1996 Daniel Grindrod (dannycg1996) commented Feb 11, 2025 •

Copy link
Copy Markdown
Collaborator

Why are these changes needed?

Previously there was an error with using sample weights and group folds together (see related issue). This PR fixes that issue, and adds a test to ensure that this stays fixed in future. I also noticed that we were importing numpy twice within test_splits.py, so I removed the defunct import statement.

Related issue number

Closes #1396

Checks

@dannycg1996

Copy link
Copy Markdown
Collaborator Author

Hi Li Jiang (@thinkall),
All of the tests seem to pass, except for those on the ubuntu 3.10 and ubuntu 3.11 builds, where test_gpu fails. Having looked at some of the other open PRs, such as #1402 and #1392, it seems that this test always fails.
Is this a test we can just ignore? If not, do you have any ideas on how to fix it?
Thanks for any help!

@thinkall Li Jiang (thinkall) mentioned this pull request Feb 12, 2025
4 tasks

@thinkall Li Jiang (thinkall) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Daniel Grindrod (@dannycg1996) for the PR! LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot Use GroupFolds With Sample Weights

2 participants