Repository navigation
Conversation
xwj-ox
changed the base branch from
u/adkrishnan/ivf-index-2
to
codex/ivf-reassignment
October 29, 2026 05:49
xwj-ox
force-pushed
the
u/xiajiang/ivf-search-benchmark
branch
from
October 29, 2026 05:49
065e35a to
b2caa87
Compare
This was referenced Oct 29, 2026
This was referenced Oct 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Stacked on #1536 (u/xiajiang/ivf-reassignment). This is the consumer at the top of the IVF stack.
Review order: #1534 -> #1535 -> #1520 -> #1536 -> #1519.
What does this implement/fix? Briefly explain your changes.
Add ivf-index to the shared benchmark runner with typed build/search inputs, a private in-memory provider, phase metrics, checkpoints and shared recall/QPS reporting. Preserve FP16/FP32 bin and fvecs loading, supplied groundtruth, build-only runs and the independent full-probe oracle. The baseline and projection-gemm JSON presets compose the independent library policies; default recall remains Recall@1000.
Any other comments?
The diff is confined to diskann-benchmark. Validation: six benchmark/integration tests passed with default features and six with both IVF features, including the supplied-truth regression. Four release CLI runs (baseline/combined, one/four threads) used 4,096 synthetic vectors and all 128 queries at Recall@1000; full-probe checks passed. Workspace and benchmark feature-matrix Clippy with warnings denied, formatting and license-header checks passed. This reports in-memory IVF-Flat behavior and does not establish a performance improvement.
The prerequisite already fails invalid_initialization_and_uninitialized_insertion_fail because NaN initial centroids are accepted. This was reproduced on unmodified base 83c0109 and remains the only failure in the full IVF suite.