镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Add IVF build and search benchmark - #1519

Draft
xwj-ox wants to merge 1 commit into
u/xiajiang/ivf-reassignmentfrom
u/xiajiang/ivf-search-benchmark
Draft

xwj-ox wants to merge 1 commit into
u/xiajiang/ivf-reassignmentfrom
u/xiajiang/ivf-search-benchmark

Conversation

@xwj-ox

@xwj-ox xwj-ox commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor
  • Does this PR have a descriptive title that could go in our release notes?
  • Does this PR add any new dependencies?
  • Does this PR modify any existing APIs?
  • Is the change to the API backwards compatible?
  • Should this result in any changes to our documentation, either updating existing docs or adding new ones?

Reference Issues/PRs

Stacked on #1536 (u/xiajiang/ivf-reassignment). This is the consumer at the top of the IVF stack.

Review order: #1534 -> #1535 -> #1520 -> #1536 -> #1519.

What does this implement/fix? Briefly explain your changes.

Add ivf-index to the shared benchmark runner with typed build/search inputs, a private in-memory provider, phase metrics, checkpoints and shared recall/QPS reporting. Preserve FP16/FP32 bin and fvecs loading, supplied groundtruth, build-only runs and the independent full-probe oracle. The baseline and projection-gemm JSON presets compose the independent library policies; default recall remains Recall@1000.

Any other comments?

The diff is confined to diskann-benchmark. Validation: six benchmark/integration tests passed with default features and six with both IVF features, including the supplied-truth regression. Four release CLI runs (baseline/combined, one/four threads) used 4,096 synthetic vectors and all 128 queries at Recall@1000; full-probe checks passed. Workspace and benchmark feature-matrix Clippy with warnings denied, formatting and license-header checks passed. This reports in-memory IVF-Flat behavior and does not establish a performance improvement.

The prerequisite already fails invalid_initialization_and_uninitialized_insertion_fail because NaN initial centroids are accepted. This was reproduced on unmodified base 83c0109 and remains the only failure in the full IVF suite.

@xwj-ox xwj-ox mentioned this pull request Oct 27, 2026
5 tasks
@xwj-ox
xwj-ox changed the base branch from u/adkrishnan/ivf-index-2 to codex/ivf-reassignment October 29, 2026 05:49
@xwj-ox
xwj-ox force-pushed the u/xiajiang/ivf-search-benchmark branch from 065e35a to b2caa87 Compare October 29, 2026 05:49
@xwj-ox xwj-ox changed the title [POC][do not review] Add IVF build and search benchmark Add IVF build and search benchmark Oct 29, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants