Repository navigation
[POC][multi-vector] Add MinMax MaxSim benchmark - #1509
Draft
juchen-ms (partychen) wants to merge 3 commits into
Draft
juchen-ms (partychen) wants to merge 3 commits into
juchen-ms (partychen) wants to merge 3 commits into
Conversation
Integrate the merged MinMax matrix kernel with an owned-query factory, runtime ISA selection, an independent scalar reference, and shared construction errors. Preserve QueryMatRef inputs and add focused factory and query-cloning coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 94d30f43-fadc-4a6b-889b-406de424a1ab
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1509 +/- ##
==========================================
- Coverage 92.16% 91.08% -1.09%
==========================================
Files 592 596 +4
Lines 123582 124095 +513
==========================================
- Hits 113901 113031 -870
- Misses 9681 11064 +1383
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Revert cb89267 while the MinMax factory API is redesigned.
4 of 5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Briefly explain your changes.
Any other comments?
MinMax MaxSim benchmark results
Timings are microseconds per MaxSim call (lower is better). The comparison workload uses 32 query vectors, 128 document vectors, and 128 dimensions, with independent query/document quantization widths of 1, 2, 4, and 8 bits.
MinMaxIPquery/document double loop, compiled for x86-64-v3—not the scalar/reference factory backend. A dash means the existing pairwise API does not support that ordered bit-width combination; no substitute implementation was measured.These results characterize repeated scoring of warm data at the stated fixed workload; they do not measure end-to-end search, cold-cache behavior, quantization accuracy, or query preparation cost.