Repository navigation
Conversation
jpr42
force-pushed
the
cmake-core-port
branch
9 times, most recently
from
August 26, 2026 01:27
0848680 to
f840ee3
Compare
jpr42
marked this pull request as draft
August 26, 2026 03:07
jpr42
force-pushed
the
cmake-core-port
branch
2 times, most recently
from
August 26, 2026 03:58
46c43db to
c53a21c
Compare
Replaces the NMake Makefiles and vc/Detours.sln with a single CMake build covering the library, unit/integration tests, and every sample NMake built (opengl excluded, as NMake never built it either). find_package(Detours) is supported and tested against a real staged install, not just an in-tree build. .github/workflows/cmake.yml replaces main.yml's NMake-driven CI with a matrix across VS2022/VS2026, Ninja, x86/x64, Debug/Release, plus a real-hardware ARM64EC job, and keeps CodeQL coverage. NMake and the VS project are removed outright now that CMake has full parity, per the maintainer's own note that CMake would obsolete both: microsoft#48 (comment) Successor to microsoft#48
jpr42
marked this pull request as ready for review
August 26, 2026 04:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the NMake Makefiles and vc/Detours.sln with a single CMake
build covering the library, unit/integration tests, and every sample
NMake built (opengl excluded, as NMake never built it either).
find_package(Detours) is supported and tested against a real staged
install, not just an in-tree build.
.github/workflows/cmake.yml replaces main.yml's NMake-driven CI with a
matrix across VS2022/VS2026, Ninja, x86/x64, Debug/Release, plus a
real-hardware ARM64EC job, and keeps CodeQL coverage.
NMake and the VS project are removed outright now that CMake has full
parity, per the maintainer's own note that CMake would obsolete both:
#48 (comment)
Successor to #48