镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

docs(agents): point the review criteria at the synced REVIEW.md - #136

Merged
kyle-sexton merged 1 commit into
mainfrom
docs/review-md-pointer
Oct 30, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
docs/review-md-pointer

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

Refs: melodic-software/standards#726

Summary

REVIEW.md now exists at this repository's root through the review-instructions sync component. The AGENTS.md Code Review Rules pointer still links the canonical URL, so the code-review-rules audit reports it as missing the local link.

Fix

Replace the URL-form pointer with a link to the local REVIEW.md, worded as in the other enrolled repositories. No CI root-coverage or path-classification step in this repository classifies top-level files, so no workflow change is needed.

Verification

  • git diff shows one changed line in AGENTS.md.
  • The audit checker's expected form is the one in the standards#726 plan.

Related

🤖 Generated with Claude Code

https://claude.ai/code/session_01VcupojYKhHyDni9LuAXBuX

@kyle-sexton
kyle-sexton marked this pull request as ready for review October 30, 2026 21:44
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T21:45:23.040896Z cb8d6f5 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed cb8d6f5dda62093765bcec5b68677c073c5ef1b0: 0 finding(s), 0 as inline comments.

No security issues found in PR #136 (head cb8d6f5).

The PR changes one line in AGENTS.md. The "Org-wide criteria" link changes from an absolute GitHub URL for melodic-software/standards to the relative REVIEW.md, which exists at the repo root.

  • Instruction surface: I read the change under the instruction-surface lens. It removes and narrows no rule and only repoints the reference at the local synced copy. I did not consult the protected-class register because nothing is removed.
  • Trust controls: none touched.
  • Manifests: none touched.

critical-findings: 0

@github-actions

Copy link
Copy Markdown

claude-review reviewed cb8d6f5dda62093765bcec5b68677c073c5ef1b0: 0 finding(s), 0 as inline comments.

No findings. The PR changes one line in AGENTS.md: the Code Review Rules pointer now links the local REVIEW.md instead of the canonical URL.

  • I confirmed REVIEW.md is tracked at the repo root, so the relative link resolves.
  • The new link matches the "Doc conventions" rule that human-facing Markdown cites repo files as resolvable relative links.
  • .github/workflows/pr-check-managed-files-hosted.yml already lists REVIEW.md as a managed file, so the sync claim holds.
  • The PR context names no closing issue with acceptance criteria; the PR only references code-review-rules: enroll the six URL-form sync targets in review-instructions standards#726 and #917. Those were not read, and nothing is claimed about them.
  • There are no manifests, sync-local code, or .claude/rules/ files in the diff to check.
  • I did not run the link or typos CI checks. The "audit checker's expected form" and "one changed line" statements in the PR's Verification section are author-claimed. I confirmed the one-line diff myself from .claude-lane/pr.diff.
  • Advisory only, not counted as a finding: the PR body opens with "Refs: code-review-rules: enroll the six URL-form sync targets in review-instructions standards#726" instead of a closing keyword or the "No related issue: " escape. AGENTS.md says that gate is advisory, so it may add the needs-issue-linkage label but won't fail the check.

@kyle-sexton
kyle-sexton merged commit 12ccd10 into main Oct 30, 2026
14 checks passed
@kyle-sexton
kyle-sexton deleted the docs/review-md-pointer branch October 30, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant