镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Fix every third list item broken - #2318

Merged
styfle merged 2 commits into
markedjs:masterfrom
calculuschild:FixThirdSublistBroken
Dec 9, 2021
Merged

styfle merged 2 commits into
markedjs:masterfrom
calculuschild:FixThirdSublistBroken

Conversation

@calculuschild

Copy link
Copy Markdown
Contributor

Marked version:

4.0.6

Description

Fixes #2314

#2302 mistakenly used list.loose as a flag to end list items early if they start with two blank lines. Technically that is a different scenario from being "loose", so legitimate loose lists were also hitting that flag and prematurely ending the list after the second item. This PR just adds a separate flag endEarly to handle that case.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel

vercel Bot commented Dec 9, 2021 •

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/DHNZFHw9M4ntqboD5p5STLypQVHA
✅ Preview: https://markedjs-git-fork-calculuschild-fixthirdsublistbroken-markedjs.vercel.app

@styfle styfle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@styfle
styfle merged commit 346b162 into markedjs:master Dec 9, 2021
github-actions Bot pushed a commit that referenced this pull request Dec 9, 2021
## [4.0.7](v4.0.6...v4.0.7) (2021-12-09)

### Bug Fixes

* Fix every third list item broken ([#2318](#2318)) ([346b162](346b162)), closes [#2314](#2314)
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 4.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

This branch was successfully deployed

1 active deployment
Preview — eed356d0 Deployed Dec 9, 2021 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sub-list items which are multiples of 3 are wrapped with pre/code blocks in version 4.0.6

3 participants