Repository navigation
Fix #1823 - task lists are rendered even when GFM is disabled - #1825
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/markedjs/markedjs/j6p2afjvu |
styfle
left a comment
There was a problem hiding this comment.
Looks good, thanks!
However, this bug has existed for at least a year so we might need to consider it a breaking change for users that have come to rely on this behavior.
Agree. Is marked ever going to use semantic versioning? Semi-related: I recently upgraded an old version of Marked and it broke even the simplest of Markdown that was supported a while ago with GFM: |
It already does follow semver, we just have to agree on what is considered a patched bug fix or is breaking. Nearly every change to marked is going to affect the resulting output so we could consider every change as major semver (besides something like an internal refactor). However, since we document that we follow the Commonmark/GFM spec, then any change to align with that spec can be considered a patch even though the output changed. In this case, since its not a fix to the spec but actually a change to the behavior to the public API, I consider this a major semver change. |
I disagree. First since This is a FIX and should be a patch. |
This is a fix to the spec. Before this fix the following markdown did not match CommonMark: - [ ] A
- [ ] B
- [ ] C |
For what it's worth, this was another fix that was made to align more closely to the Markdown spec. The extra spaces in It is true that the presence of bugs sometimes means people come to expect a certain behavior, but as @UziTech says, I don't think a patch to fix those bugs requires a major version bump, even if people have unknowingly come to rely on them. |
|
#1834 was just merged to clarify our versioning strategy. https://marked.js.org/publishing#versioning I think since this PR moves Marked closer to CommonMark compliance and does not touch our public API it should be a patch update. |
|
If this can get one more approval we can merge it |
|
🎉 This PR is included in version 1.2.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [1.2.5](markedjs/marked@v1.2.4...v1.2.5) (2020-11-19) ### Bug Fixes * fix em and strong starting with special char ([#1832](markedjs/marked#1832)) ([3658df4](markedjs/marked@3658df4)) * task lists not rendered when GFM is disabled ([#1825](markedjs/marked#1825)) ([aeaa393](markedjs/marked@aeaa393)), closes [#1823](markedjs/marked#1823)

Marked version:
1.2.3
Markdown flavor:
All except GitHub Flavored Markdown
Description
Contributor
Committer
In most cases, this should be a different person than the contributor.